Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: update publishing workflow #3437

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

nilason
Copy link
Contributor

@nilason nilason commented Feb 19, 2024

Generates Git derived data files, which are added to release tarballs of both *.tar.gz and tar.xz formats. Accompanied by md5 and sha256 checksum files.

Solves #3430, depends on #3435.

Initially put up as draft, if this agreed upon the howto_release.md need to be updated.

@nilason nilason added this to the 8.4.0 milestone Feb 19, 2024
@github-actions github-actions bot added the CI Continuous integration label Feb 19, 2024
@nilason
Copy link
Contributor Author

nilason commented Feb 19, 2024

This has also to be combined somehow with create_release_draft.yml.

@nilason
Copy link
Contributor Author

nilason commented Feb 20, 2024

Updated this workflow to re-use (update) create_release_draft.yml.

Now it also contains the core_modules_with_last_commit.patch, but not the json file (as it is already included in tarball).

This keeps the previous behaviour and adds the new release packages.

Assets created:

ChangeLog.gz
core_modules_with_last_commit.patch
grass-${version}.tar.gz
grass-${version}.tar.gz.md5
grass-${version}.tar.gz.sha256
grass-${version}.tar.xz
grass-${version}.tar.xz.md5
grass-${version}.tar.xz.sha256
Source code (zip)
Source code (tar.gz)

@nilason
Copy link
Contributor Author

nilason commented Feb 20, 2024

This now fails because it is missing #3435.

Se my bogus test release for result.

@nilason
Copy link
Contributor Author

nilason commented Feb 20, 2024

Side note:
This workflow (before this PR) use the two https://github.com/actions/upload-release-asset https://github.com/actions/create-release actions, which are both no more maintained (archived).

The single use of https://github.com/softprops/action-gh-release replaces them and also the https://github.com/actions/upload-artifact.

@nilason nilason self-assigned this Feb 20, 2024
@nilason nilason marked this pull request as ready for review February 20, 2024 15:51
@echoix
Copy link
Member

echoix commented Feb 28, 2024

Was this ready and intended to be merged? I know we need to ignore the failure in the new workflow for now due to to missing parts

@nilason
Copy link
Contributor Author

nilason commented Feb 29, 2024

Was this ready and intended to be merged?

Yes. As this now re-use the create_release_draft.yml workflow, Readme doesn't need to be updated (I believe).

@echoix
Copy link
Member

echoix commented Feb 29, 2024

Is #3435 still a requirement? If so we could sprint it up a little

.github/workflows/create_release_draft.yml Show resolved Hide resolved
.github/workflows/create_release_draft.yml Outdated Show resolved Hide resolved
@echoix
Copy link
Member

echoix commented Mar 24, 2024

Before merging this PR, it might need a new title, since it isn't a new workflow. Also, is the existing workflow file name still appropriate for what it now does? If ever it is changed, since the contents of the workflow changed a lot, maybe we would need a mini PR that renames the file before this PR is merged, to be able to follow the file history after renames.

Generates Git derived data files, which are added to release tarballs
of both `*.tar.gz` and `tar.xz` formats. Accompanied by `md5` and
`sha256` checksum files.
@nilason nilason changed the title CI: add publish workflow CI: update publishing workflow Mar 25, 2024
@nilason
Copy link
Contributor Author

nilason commented Mar 25, 2024

Before merging this PR, it might need a new title, since it isn't a new workflow.

Done.

Also, is the existing workflow file name still appropriate for what it now does?

I think the file name is quite ok, reflecting what it does, no need to change.

@nilason nilason enabled auto-merge (squash) March 25, 2024 15:37
@nilason nilason merged commit 704f446 into OSGeo:main Mar 25, 2024
27 checks passed
@nilason nilason deleted the ci_add_publish_workflow branch May 15, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants