Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] g.gui.gcp: Georectification setting fails with a TypeError ColumnSorterMixin #4277

Closed
mshukuno opened this issue Sep 5, 2024 · 8 comments · Fixed by #4310
Closed
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@mshukuno
Copy link
Contributor

mshukuno commented Sep 5, 2024

Describe the bug

There is an error when setting up the georectification tool. Please see the traceback below.

Traceback (most recent call last):
  File
"/usr/local/grass85/gui/wxpython/main_window/frame.py", line
888, in OnGCPManager

GCPWizard(self, self._giface)
  File "/usr/local/grass85/gui/wxpython/gcp/manager.py",
line 308, in __init__

gcpmgr.InitMapDisplay()
  File "/usr/local/grass85/gui/wxpython/gcp/manager.py",
line 1275, in InitMapDisplay

ColumnSorterMixin(self, ncols)
TypeError
:
ColumnSorterMixin.__init__() takes 2 positional arguments
but 3 were given

To reproduce

Please refer to the following Screenshots.

Screenshots

Here is the setup I attempted.
g_gui_gcp_1
g_gui_gcp_2
g_gui_gcp_3
g_gui_gcp_4

System description

  • Operating System: Ubuntu 22.04 LTS

  • GRASS GIS version:
    version=8.5.0dev
    date=2024
    revision=37f4c3af05
    build_date=2024-09-03
    build_platform=x86_64-pc-linux-gnu
    build_off_t_size=8
    libgis_revision=b794d95393
    libgis_date=2024-08-23T16:29:27+00:00
    proj=9.1.1
    gdal=3.6.4
    geos=3.12.2
    sqlite=3.37.2

  • details about further software components
    3.10.12 (main, Jul 29 2024, 16:56:48) [GCC 11.4.0]
    4.2.1 gtk3 (phoenix) wxWidgets 3.2.2.1

@mshukuno mshukuno added the bug Something isn't working label Sep 5, 2024
@petrasovaa
Copy link
Contributor

This should probably be ColumnSorterMixin.__init__(self, ncols)

@petrasovaa petrasovaa added the good first issue Good for newcomers label Sep 5, 2024
@petrasovaa petrasovaa added this to the 8.4.1 milestone Sep 5, 2024
@rohannallamadge
Copy link
Contributor

rohannallamadge commented Sep 11, 2024

hello can you this issue to me , i am interested to solve this

@echoix
Copy link
Member

echoix commented Sep 12, 2024

hello can you this issue to me , i am interested to solve this

I invite you to try creating your first PR by making some changes in a branch of your fork of the repo. Take a look at the contributing guide to get help getting started if needed :)

Looking forward to see your work!

rohannallamadge added a commit to rohannallamadge/grass that referenced this issue Sep 12, 2024
rohannallamadge added a commit to rohannallamadge/grass that referenced this issue Sep 12, 2024
@rohannallamadge
Copy link
Contributor

here i just fixed typeError columnsortedmixin and updated system description
Screenshot 2024-09-12 171420
Screenshot 2024-09-12 171333

rohannallamadge added a commit to rohannallamadge/grass that referenced this issue Sep 12, 2024
rohannallamadge added a commit to rohannallamadge/grass that referenced this issue Sep 12, 2024
rohannallamadge added a commit to rohannallamadge/grass that referenced this issue Sep 12, 2024
rohannallamadge added a commit to rohannallamadge/grass that referenced this issue Sep 12, 2024
@petrasovaa petrasovaa linked a pull request Sep 12, 2024 that will close this issue
echoix pushed a commit that referenced this issue Sep 12, 2024
* fixing TypeError ColumnSorterMixin #4277

* #4277 fix ColumnSorterMixin error
@neteler
Copy link
Member

neteler commented Sep 12, 2024

@petrasovaa will you backport this?

@echoix
Copy link
Member

echoix commented Sep 12, 2024

It should have been introduced only 3 weeks ago

@neteler
Copy link
Member

neteler commented Sep 12, 2024

It should have been introduced only 3 weeks ago

I see - she marked it as 8.4.1, that's why...

@petrasovaa petrasovaa modified the milestones: 8.4.1, 8.5.0 Sep 13, 2024
@petrasovaa
Copy link
Contributor

It should have been introduced only 3 weeks ago

I see - she marked it as 8.4.1, that's why...

Sorry, my mistake

Mahesh1998 pushed a commit to Mahesh1998/grass that referenced this issue Sep 19, 2024
* fixing TypeError ColumnSorterMixin OSGeo#4277

* OSGeo#4277 fix ColumnSorterMixin error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants