-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wxGUI/mapdisp: it is also possible to remove the MASK interactively #1176
wxGUI/mapdisp: it is also possible to remove the MASK interactively #1176
Conversation
af6c4c3
to
653ee28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not completely sure if making it a button is super intuitive, but probably better than current situation. So I think it is fine, my concern is we may need to change this in the future to better work with single-window layout. But we don't have a clear plan on simplifying the statusbar yet, so this PR may be fine.
I would merge it though after branching GRASS 8 release branch.
gui/wxpython/mapdisp/statusbar.py
Outdated
|
||
def __init__(self, mapframe, statusbar, position=0): | ||
SbItem.__init__(self, mapframe, statusbar, position) | ||
self._mapframe = mapframe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't there already self.mapframe in SbItem constructor?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's there (in base class), I removed this redundant line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are still calling self._mapframe.OnRender...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs self._mapframe -> self.mapFrame
With left mouse click on the MASK button widget inside statusbar.
1970d81
to
6ca6f70
Compare
You are right. I've already fixed it. |
…SGeo#1176) With left mouse click on the MASK button widget inside statusbar.
…SGeo#1176) With left mouse click on the MASK button widget inside statusbar.
It is also possible to remove the MASK interactively (left mouse click on the button MASK widget inside statusbar).
Current behavior:
Suggested behavior: