-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wxGUI: fix 'SpinCtrl' widget size #1339
wxGUI: fix 'SpinCtrl' widget size #1339
Conversation
So I am wondering, why do you use other values (e.g. 137) in this PR? |
Because
I tested on one of the default GTK+ theme Adwaita
I haven't tested it on other OS yet. |
If it's a bug in GTK+ or in the theme, then it doesn't make sense to solve it at the wxPython level. |
@tmszi would you mind to rebase this PR? |
It seems this bug related with wxGTK+ theme, I'll take another look at it. |
Bumping up milestone as 8.0.1 is due in two days, while this has not been part of RC1 and there has not been activity for some time. |
… arg min=1, max=100 which is 118
…1, max=1e6 which is 137
…1e9, max=1e9 which is 148
…=1, max=1e6 which is 137
… max=1e6 which is 137
a31b1ff
to
97f8fa3
Compare
In general, using sizers and not setting size explicitly works best, so I changed the SpinCtrl wrapper to (on gtk) ignore size parameter if it's smaller than the minimum you identified, so that we don't have to remove all the size parameters directly. I removed couple size settings which were greater than the minimum and would likely cause troubles. I haven't seen any problems so far and it shouldn't break anything. This PR definitely helps with getting rid of many Gtk-critical messages. |
This is great news! |
In general, using sizers and not setting size explicitly works best, so I changed the SpinCtrl wrapper to (on gtk) ignore size parameter if it's smaller than the minimum you identified, so that we don't have to remove all the size parameters directly. I removed couple size settings which were greater than the minimum and would likely cause troubles. This should help with getting rid of many Gtk-critical messages.
Backport done |
In general, using sizers and not setting size explicitly works best, so I changed the SpinCtrl wrapper to (on gtk) ignore size parameter if it's smaller than the minimum you identified, so that we don't have to remove all the size parameters directly. I removed couple size settings which were greater than the minimum and would likely cause troubles. This should help with getting rid of many Gtk-critical messages.
In general, using sizers and not setting size explicitly works best, so I changed the SpinCtrl wrapper to (on gtk) ignore size parameter if it's smaller than the minimum you identified, so that we don't have to remove all the size parameters directly. I removed couple size settings which were greater than the minimum and would likely cause troubles. This should help with getting rid of many Gtk-critical messages.
In general, using sizers and not setting size explicitly works best, so I changed the SpinCtrl wrapper to (on gtk) ignore size parameter if it's smaller than the minimum you identified, so that we don't have to remove all the size parameters directly. I removed couple size settings which were greater than the minimum and would likely cause troubles. This should help with getting rid of many Gtk-critical messages.
To Reproduce
Steps to reproduce the behavior:
g.gui.dbmgr map=roadsmajor
SpinCtrl
widgetError message
Additional info
Bug related with size of
SpinCtrl
widget (wxGTK only) which is different according input param argmin=, max=
. According my testing, width threshold value forSpinCtrl
widget with default param argmin=1, max=100
is 118 (bug not occur).I also fixed this in other wxGUI components using this widget.