Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use copy instead of git clone in Dockerfiles #151

Merged
merged 3 commits into from
Oct 15, 2019

Conversation

mmacata
Copy link
Contributor

@mmacata mmacata commented Oct 9, 2019

This PR suggests to change the current behaviour of using git clone in the Dockerfiles. Before, the GRASS GIS version needed to be configured via ARG variables to clone the branch according to the wanted GRASS version. As the source code is here and next to the Dockerfiles already, a simple COPY can be used. The GRASS version then corresponds to the branch on which the Dockerimage is build.

Additionally a .dockerignore file was added to not copy the whole context on build time.

An example docker build can be done now with:

$ docker build \
         --file docker/debian/Dockerfile_debian_pdal \
         --tag grass-py3-pdal:latest-debian .

and to build a stable version:

$ git checkout remotes/origin/releasebranch_7_8
$ docker build \
         -f docker/debian/Dockerfile_debian_pdal \
         -t grass-py3-pdal:stable-debian .

Currently, this leads to the following flavours:

master:

  • grass-py3-pdal:latest-ubuntu (GRASS GIS 7.9, proj=4.9.3, gdal=2.2.3, geos=3.6.2, sqlite=3.22.0, pdal 1.8.0, Python 3.6.8)
  • grass-py3-pdal:latest-debian (GRASS GIS 7.9, proj=5.2.0, gdal=2.4.0, geos=3.7.1, sqlite=3.27.2, pdal 1.8.0, Python 3.7.3)
  • grass-py3-pdal:latest-alpine (GRASS GIS 7.9, proj=5.2.0, gdal=2.4.0, geos=3.7.2, sqlite=3.29.0, pdal 1.9.1, Python 3.7.4)

releasebranch_7_8:

  • grass-py3-pdal:stable-ubuntu (GRASS GIS 7.8.1, proj=4.9.3, gdal=2.2.3, geos=3.6.2, sqlite=3.22.0, pdal 1.8.0, Python 3.6.8)
  • grass-py3-pdal:stable-debian (GRASS GIS 7.8.1, proj=5.2.0, gdal=2.4.0, geos=3.7.1, sqlite=3.27.2, pdal 1.8.0, Python 3.7.3)
  • grass-py3-pdal:stable-alpine (GRASS GIS 7.8.1, proj=5.2.0, gdal=2.4.0, geos=3.7.2, sqlite=3.29.0, pdal 1.9.1, Python 3.7.4)

Copy link
Member

@neteler neteler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks

@neteler neteler merged commit 55723ae into OSGeo:master Oct 15, 2019
@neteler
Copy link
Member

neteler commented Oct 15, 2019

Backported to relbranch78 in d328446

petrasovaa pushed a commit to petrasovaa/grass that referenced this pull request Dec 3, 2019
landam pushed a commit to landam/grass that referenced this pull request Jan 28, 2020
@neteler neteler added this to the 7.8.1 milestone Dec 9, 2021
@mmacata mmacata deleted the docker-copy branch March 29, 2022 07:51
@mmacata mmacata restored the docker-copy branch March 29, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants