use copy instead of git clone in Dockerfiles #151
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests to change the current behaviour of using
git clone
in the Dockerfiles. Before, the GRASS GIS version needed to be configured viaARG
variables to clone the branch according to the wanted GRASS version. As the source code is here and next to the Dockerfiles already, a simpleCOPY
can be used. The GRASS version then corresponds to the branch on which the Dockerimage is build.Additionally a .dockerignore file was added to not copy the whole context on build time.
An example docker build can be done now with:
$ docker build \ --file docker/debian/Dockerfile_debian_pdal \ --tag grass-py3-pdal:latest-debian .
and to build a stable version:
$ git checkout remotes/origin/releasebranch_7_8 $ docker build \ -f docker/debian/Dockerfile_debian_pdal \ -t grass-py3-pdal:stable-debian .
Currently, this leads to the following flavours:
master:
releasebranch_7_8: