g.extension: only warn when non-essential files are missing #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only warn, not fatal error, when CSS and logo files are missing in the distribution. Tell user about the possibility of missing a doc pkg. Tell what will happen next. Also improve function and parameter names. and switch to format and name vars in now more complex tr string.
neteler
pushed a commit
that referenced
this pull request
Oct 27, 2019
Only warn, not fatal error, when CSS and logo files are missing in the distribution. Tell user about the possibility of missing a doc pkg. Tell what will happen next. Also improve function and parameter names. and switch to format and name vars in now more complex tr string.
|
backported in d8247df |
petrasovaa
pushed a commit
to petrasovaa/grass
that referenced
this pull request
Dec 3, 2019
Only warn, not fatal error, when CSS and logo files are missing in the distribution. Tell user about the possibility of missing a doc pkg. Tell what will happen next. Also improve function and parameter names. and switch to format and name vars in now more complex tr string.
landam
pushed a commit
to landam/grass
that referenced
this pull request
Jan 28, 2020
Only warn, not fatal error, when CSS and logo files are missing in the distribution. Tell user about the possibility of missing a doc pkg. Tell what will happen next. Also improve function and parameter names. and switch to format and name vars in now more complex tr string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only warn, not fatal error, when CSS and logo files are missing
in the distribution. Tell user about the possibility of
missing a doc pkg. Tell what will happen next.
Also improve function and parameter names.
and switch to format and name vars in now more
complex tr string.
This is particularly useful when you don't have grass-doc package installed and you don't want to install it, but want to install modules using g.extension.