Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a standard option for nprocs= (G_OPT_M_NPROCS) #1644

Merged
merged 2 commits into from
Jun 16, 2021

Conversation

HuidaeCho
Copy link
Member

This PR implements the standard G_OPT_M_NPROCS option for the number of threads for parallel computing. See #1634 (comment).

@HuidaeCho HuidaeCho requested a review from ninsbl June 13, 2021 21:30
@HuidaeCho HuidaeCho added the enhancement New feature or request label Jun 13, 2021
@HuidaeCho HuidaeCho mentioned this pull request Jun 13, 2021
11 tasks
Copy link
Member

@ninsbl ninsbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up so swiftly. One question: should it be backported?
It is a new feature but very little invasive.
With regards to usage in AddOns backporting may be an advantage to safeguard AddOn-compatibility across versions...

@HuidaeCho
Copy link
Member Author

Thanks for following up so swiftly. One question: should it be backported?
It is a new feature but very little invasive.
With regards to usage in AddOns backporting may be an advantage to safeguard AddOn-compatibility across versions...

I think it makes sense to backport it.

@neteler neteler added this to the 7.8.7 milestone Jun 14, 2021
@HuidaeCho HuidaeCho merged commit d2a5e8e into OSGeo:master Jun 16, 2021
HuidaeCho added a commit to HuidaeCho/grass that referenced this pull request Jun 16, 2021
* Add a standard option for nprocs= (G_OPT_M_NPROCS)

* tabs to spaces
@HuidaeCho
Copy link
Member Author

Backport PR in #1648

@wenzeslaus
Copy link
Member

Here, many tests fail which don't fail on master. They fail on master in the commit subsequent to this one (there is only one at this point) and they fail in an PR which merged the current master (so it fails the same way in 4 different instances and tracks lead here).

Also, the code says "Values also need to be added to general/g.parser/standard_option.c".

@HuidaeCho
Copy link
Member Author

Do only tests fail? The core compiles fine on my machine. Let me add it to standard_option.c.

@HuidaeCho
Copy link
Member Author

How can I reproduce it?

@wenzeslaus
Copy link
Member

Do only tests fail?

You can see that when you click the red x ❌. In the overview, it will mark the failing jobs, when you click it, it will go to the end of the failing step in that job. Tests fail slow (i.e., they don't fail fast) so you may need to scroll up to see which test(s) are failing.

The core compiles fine on my machine.

Many things need to run to see if they work. That's why we have the tests, so hooray for the tests! 🎉 We need more of them!

How can I reproduce it?

Pick what you need from: https://grass.osgeo.org/grass80/manuals/libpython/gunittest_running_tests.html

HuidaeCho added a commit that referenced this pull request Jun 18, 2021
…1648)

* Add a standard option for nprocs= (G_OPT_M_NPROCS) (#1644)

* Add a standard option for nprocs= (G_OPT_M_NPROCS)

* tabs to spaces

* g.parser: Add G_OPT_M_NPROCS (#1652)
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
* Add a standard option for nprocs= (G_OPT_M_NPROCS)

* tabs to spaces
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
* Add a standard option for nprocs= (G_OPT_M_NPROCS)

* tabs to spaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants