-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a standard option for nprocs= (G_OPT_M_NPROCS) #1644
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for following up so swiftly. One question: should it be backported?
It is a new feature but very little invasive.
With regards to usage in AddOns backporting may be an advantage to safeguard AddOn-compatibility across versions...
I think it makes sense to backport it. |
* Add a standard option for nprocs= (G_OPT_M_NPROCS) * tabs to spaces
Backport PR in #1648 |
Here, many tests fail which don't fail on master. They fail on master in the commit subsequent to this one (there is only one at this point) and they fail in an PR which merged the current master (so it fails the same way in 4 different instances and tracks lead here). Also, the code says "Values also need to be added to general/g.parser/standard_option.c". |
Do only tests fail? The core compiles fine on my machine. Let me add it to standard_option.c. |
How can I reproduce it? |
You can see that when you click the red x ❌. In the overview, it will mark the failing jobs, when you click it, it will go to the end of the failing step in that job. Tests fail slow (i.e., they don't fail fast) so you may need to scroll up to see which test(s) are failing.
Many things need to run to see if they work. That's why we have the tests, so hooray for the tests! 🎉 We need more of them!
Pick what you need from: https://grass.osgeo.org/grass80/manuals/libpython/gunittest_running_tests.html |
* Add a standard option for nprocs= (G_OPT_M_NPROCS) * tabs to spaces
* Add a standard option for nprocs= (G_OPT_M_NPROCS) * tabs to spaces
This PR implements the standard G_OPT_M_NPROCS option for the number of threads for parallel computing. See #1634 (comment).