r.resamp.filter: implement parallelization with OpenMP #1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenzeslaus
added
enhancement
marisn
approved these changes
Aug 6, 2021
HuidaeCho
reviewed
Aug 12, 2021
raster/r.resamp.filter/main.c
Outdated
| static DCELL **bufs; | ||
| static DCELL ***bufs; | ||
| static int bufrows; | ||
| static int nprocs; |
There was a problem hiding this comment.
Delete this line if not used.
main.c:169:12: warning: ‘nprocs’ defined but not used [-Wunused-variable]
static int nprocs;
HuidaeCho
reviewed
Aug 12, 2021
| } parm; | ||
| struct | ||
| { | ||
| struct Flag *nulls; | ||
| } flag; | ||
| char title[64]; | ||
| int i; | ||
| int i, t; | ||
| int nprocs; |
There was a problem hiding this comment.
Or did you mean to use the static nprocs above?
aaronsms
force-pushed
the
parallel-r.resamp.filter
branch
2 times, most recently
from
2c9f530
to
46c607d
Compare
aaronsms
force-pushed
the
parallel-r.resamp.filter
branch
from
46c607d
to
6b73d25
Compare
nilason
approved these changes
Jan 4, 2023
There was a problem hiding this comment.
Code looks good to me and test succeeds on Mac.
Great!
Minor suggestion though:
--- a/raster/r.resamp.filter/main.c
+++ b/raster/r.resamp.filter/main.c
@@ -107,7 +107,7 @@ static const struct filter_type menu[] = {
{"hann", f_hann, 0},
{"hamming", f_hamming, 0},
{"blackman", f_blackman, 0},
- {NULL},
+ {NULL, NULL, 0},
};
|
Thank you for the review, I will merge now. #2692 needs to be again updated. |
Done. |
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Feb 17, 2023
neteler
pushed a commit
to nilason/grass
that referenced
this pull request
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklists before merging: