Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r.in.wms: gdal user:password support #196

Merged
merged 5 commits into from
Nov 18, 2019

Conversation

anikaweinmann
Copy link
Contributor

  • add wms version 1.1.0
  • add user:password to GDAL driver version

Copy link
Member

@neteler neteler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fixes the bug that user/password are not passed on when using the WMS_GDAL driver.

Locally tested, works.

@anikaweinmann
Copy link
Contributor Author

Added debugging the WMS request xml and if for the case that there are no user and password set.

anikaweinmann and others added 2 commits November 18, 2019 13:11
Co-Authored-By: Markus Neteler <neteler@gmail.com>
Copy link
Member

@neteler neteler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, thanks

@neteler neteler merged commit cd25ae2 into OSGeo:master Nov 18, 2019
neteler added a commit that referenced this pull request Nov 18, 2019
* add wms_version 1.1.0
* add user:pw for GDAL driver
* add debug and if the params are set

Co-Authored-By: Markus Neteler <neteler@mundialis.de>
@neteler
Copy link
Member

neteler commented Nov 18, 2019

Backported to relbranch78 in 78dc9c9

petrasovaa pushed a commit to petrasovaa/grass that referenced this pull request Dec 3, 2019
* add wms_version 1.1.0
* add user:pw for GDAL driver
* add debug and if the params are set

Co-Authored-By: Markus Neteler <neteler@mundialis.de>
landam pushed a commit to landam/grass that referenced this pull request Jan 28, 2020
* add wms_version 1.1.0
* add user:pw for GDAL driver
* add debug and if the params are set

Co-Authored-By: Markus Neteler <neteler@mundialis.de>
@neteler neteler added this to the 7.8.2 milestone Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants