-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
init: Fix loading of language override setting. Fixes #1489 #1990
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as far as replacing the outdated code except for that error handling of the open function. Just for the record, I'm not looking much further (the function is almost 200 lines long).
Better don't ;-) There is a reason why the code is so long – for every line there is a system where another path to failure was found. |
@marisn Feel free to backport. Thanks. |
Thanks, @neteler |
The problem was caused by a new settings file.
The problem was caused by a new settings file.
Setting of language override was broken as GUI now stores settings in a different file. This PR restores back old functionality by reading the setting from the new settings file.