Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init: Fix loading of language override setting. Fixes #1489 #1990

Merged
merged 2 commits into from
Nov 27, 2021
Merged

init: Fix loading of language override setting. Fixes #1489 #1990

merged 2 commits into from
Nov 27, 2021

Conversation

marisn
Copy link
Contributor

@marisn marisn commented Nov 25, 2021

Setting of language override was broken as GUI now stores settings in a different file. This PR restores back old functionality by reading the setting from the new settings file.

@marisn marisn linked an issue Nov 25, 2021 that may be closed by this pull request
[Bug] Unable to change language settings #1489
Closed
@marisn marisn mentioned this pull request Nov 25, 2021
Closed
wenzeslaus
wenzeslaus requested changes Nov 26, 2021
View reviewed changes
Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as replacing the outdated code except for that error handling of the open function. Just for the record, I'm not looking much further (the function is almost 200 lines long).

lib/init/grass.py Outdated Show resolved Hide resolved
lib/init/grass.py Outdated Show resolved Hide resolved
@marisn
Copy link
Contributor Author

marisn commented Nov 26, 2021

Just for the record, I'm not looking much further (the function is almost 200 lines long).

Better don't ;-) There is a reason why the code is so long – for every line there is a system where another path to failure was found.

@marisn marisn merged commit 8ae6631 into OSGeo:main Nov 27, 2021
@marisn marisn deleted the fix_locale_override branch November 27, 2021 15:26
@landam
Copy link
Member

landam commented Nov 27, 2021

@marisn Feel free to backport. Thanks.

@landam landam added this to the 8.0.0 milestone Nov 27, 2021
neteler pushed a commit that referenced this pull request Nov 28, 2021
@marisn @neteler
Fix loading of language override setting. Fixes #1489 (#1990)
5eb6adf 
The problem was caused by a new settings file.
@marisn
Copy link
Contributor Author

marisn commented Nov 28, 2021

Thanks, @neteler

@wenzeslaus wenzeslaus changed the title Fix loading of language override setting. Fixes #1489 init: Fix loading of language override setting. Fixes #1489 Apr 27, 2022
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
@marisn @ninsbl
Fix loading of language override setting. Fixes OSGeo#1489 (OSGeo#1990)
005e99e 
The problem was caused by a new settings file.
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
@marisn @ninsbl
Fix loading of language override setting. Fixes OSGeo#1489 (OSGeo#1990)
2de23e8 
The problem was caused by a new settings file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenzeslaus wenzeslaus wenzeslaus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

[Bug] Unable to change language settings
4 participants
@marisn @landam @wenzeslaus @neteler