Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TGIS: number_of_bands -> number_of_semantic_labels #2011

Merged
merged 4 commits into from
Dec 12, 2021

Conversation

landam
Copy link
Member

@landam landam commented Dec 10, 2021

This PR changes TGIS DB attribute from number_of_bands to number_of_semantic_labels as discussed in #1454 (comment).

After registering two Sentinel bands:

T35VLG_20211016T094029_B03_10m|2021-10-16 09:43:56.893568|S2_3
T35VLG_20211016T094029_B02_10m|2021-10-16 09:43:56.893568|S2_2

t.info reports:

 | Number of semantic labels:.. 2
 | Semantic labels:............ S2_2,S2_3
number_of_semantic_labels=2
semantic_labels=S2_2,S2_3

Bumping this PR as blocker for GRASS 8.0 because TGIS DB attribute name is changed.

@landam landam added blocker Blocking a release temporal Related to temporal data processing labels Dec 10, 2021
@landam landam added this to the 8.0.0 milestone Dec 10, 2021
@landam landam self-assigned this Dec 10, 2021
Copy link
Contributor

@veroandreo veroandreo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistency, I like it :)

@landam landam merged commit 598f1e9 into OSGeo:main Dec 12, 2021
@landam landam deleted the tgis_bands2semantic_labels branch December 12, 2021 15:58
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Blocking a release temporal Related to temporal data processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants