Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools/mkhtml.py: replace f-string with format() function to maintain compatibility with Python 3.5/2.7 version #2077

Merged
merged 1 commit into from
Jan 12, 2022
Merged

tools/mkhtml.py: replace f-string with format() function to maintain compatibility with Python 3.5/2.7 version #2077

merged 1 commit into from
Jan 12, 2022

Conversation

tmszi
Copy link
Member

@tmszi tmszi commented Jan 10, 2022

Fixes #2070.

@tmszi
tools/mkhtml.py: replace f-string with format() function
68882c9 
To maintain compatibility with Python 3.5/2.7 version.
@tmszi tmszi added the Python Related code is in Python label Jan 10, 2022
@tmszi tmszi requested a review from neteler January 10, 2022 12:03
@neteler
Copy link
Member

neteler commented Jan 10, 2022

Works fine (locally tested).

Not sure but does it also address

OSGeo/grass-addons#601 (comment)

or is it unrelated?

@tmszi
Copy link
Member Author

tmszi commented Jan 10, 2022 •
edited
Loading

Works fine (locally tested).

Not sure but does it also address

OSGeo/grass-addons#601 (comment)

or is it unrelated?

Works fine (locally tested).

Not sure but does it also address

OSGeo/grass-addons#601 (comment)

or is it unrelated?

It isn't related with this PR.

Because variables (see below) are hardcoded and G7 addon URL source code a history point to grass8 git branch (server osgeo lxd container). Normal user addon installation with g.extension is not affected.

GMAJOR=8
GMINOR=0

https://github.com/OSGeo/grass-addons/blob/305ba6be59f479cb5e706de9cba48f40ef388e7c/utils/cronjobs_osgeo_lxd/compile_addons_git.sh#L144

https://github.com/OSGeo/grass-addons/blob/grass8/utils/cronjobs_osgeo_lxd/cron_grass7_relbranch_build_binaries.sh#L240

@tmszi
Copy link
Member Author

tmszi commented Jan 12, 2022

Could @neteler approve this PR, please? Thanks.

@tmszi tmszi merged commit 71d79e8 into OSGeo:releasebranch_7_8 Jan 12, 2022
@tmszi tmszi deleted the mkhtml-replace-f-string-with-format-func branch January 12, 2022 12:33
@tmszi tmszi mentioned this pull request Jan 13, 2022
Closed
@wenzeslaus wenzeslaus added this to the 7.8.7 milestone Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neteler neteler neteler approved these changes

Assignees
No one assigned
Labels
Python Related code is in Python
Projects
None yet
Milestone
7.8.7
Development

Successfully merging this pull request may close these issues.
3 participants
@tmszi @neteler @wenzeslaus