-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
g.extension.all: Fix reinstall of multi-addons #2082
g.extension.all: Fix reinstall of multi-addons #2082
Conversation
There is still an (unrelated) glitch in the OSGeo4W CI:
I wonder (since it worked elsewhere; after merge of #2074 yesterday) if this PR simply needs a rebase? |
When reinstalled addon is complex type addon e.g. wx.metadata which have multiple modules e.g. g.gui.cswbrowser and etc. for every single module is return wx.metadata addon name to avoid install individual modules which isn't possible and causes an error. For finding correct addon name is using modules.xml file, which have to exists on the osgeo server for download.
6b2ecb5
to
2b38397
Compare
Rebase 2b38397. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor suggestions in messages
This commit 029cd8e has led to a change C:\OSGeo4W\opt\grass\grass80.bat -> C:\OSGeo4W\opt\grass\grass81.bat. |
I have tested it with the freshly compiled G81, An (unrelated?) slighlty confusing message occurs with the multi-addons:
But perhaps that's for a separate PR. |
It is just a warning message not bug in this case (I will try to explain below, which is justified there) and it is not related to this PR. Multi-addons e.g. i.sentinel contains multiple individual addons. Every individual addons i.sentinel.coverage, i.sentinel.download, But root addon directory i.sentinel doesn't have Python/C source file (module), contain only root addon manual html page, which is installed and therefore users will see this warning message. |
When reinstalled addon is multi-addon e.g. wx.metadata which contains multiple individual addons e.g. g.gui.cswbrowser and etc. for every single addons is returned wx.metadata multi-addon name, to avoid install individual addons which isn't possible and causes an error. For finding correct muli-addon name is using modules.xml file, which have to exists on the osgeo server for download.
When reinstalled addon is multi-addon e.g. wx.metadata which contains multiple individual addons e.g. g.gui.cswbrowser and etc. for every single addons is returned wx.metadata multi-addon name, to avoid install individual addons which isn't possible and causes an error. For finding correct muli-addon name is using modules.xml file, which have to exists on the osgeo server for download.
When reinstalled addon is multi-addon e.g. wx.metadata which contains multiple individual addons e.g. g.gui.cswbrowser and etc. for every single addons is returned wx.metadata multi-addon name, to avoid install individual addons which isn't possible and causes an error. For finding correct muli-addon name is using modules.xml file, which have to exists on the osgeo server for download.
When reinstalled addon is multi-addon e.g. wx.metadata which contains multiple individual addons e.g. g.gui.cswbrowser and etc. for every single addons is returned wx.metadata multi-addon name, to avoid install individual addons which isn't possible and causes an error. For finding correct muli-addon name is using modules.xml file, which have to exists on the osgeo server for download.
When reinstalled addon is multi-addon e.g. wx.metadata which contains multiple individual addons e.g. g.gui.cswbrowser and etc. for every single addons is returned wx.metadata multi-addon name, to avoid install individual addons which isn't possible and causes an error. For finding correct muli-addon name is using modules.xml file, which have to exists on the osgeo server for download.
Describe the bug
Reinstall multi-addon e.g. wx.metadata (which contains multiple individual modules), doesn't work.
To Reproduce
Steps to reproduce the behavior:
g.extension wx.metadata
g.extension.all -f
Expected behavior
Reinstall multi-addon e.g. wx.metadata (which contains multiple individual modules), should be work.
System description:
Additional context
Affected is reinstallation of the multi-addons (which contains multiple individual modules) e.g. wx.metadata, r.connectivity etc.