g.extension.all: Fix reinstall of multi-addons #2082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neteler
reviewed
Jan 12, 2022
neteler
reviewed
Jan 12, 2022
neteler
reviewed
Jan 12, 2022
tmszi
changed the title
|
There is still an (unrelated) glitch in the OSGeo4W CI: I wonder (since it worked elsewhere; after merge of #2074 yesterday) if this PR simply needs a rebase? |
When reinstalled addon is complex type addon e.g. wx.metadata which have multiple modules e.g. g.gui.cswbrowser and etc. for every single module is return wx.metadata addon name to avoid install individual modules which isn't possible and causes an error. For finding correct addon name is using modules.xml file, which have to exists on the osgeo server for download.
tmszi
force-pushed
the
g_extension_all-fix-reinstallation-of-complex-addons
branch
from
6b2ecb5
to
2b38397
Compare
|
Rebase 2b38397. |
veroandreo
reviewed
Jan 12, 2022
This commit 029cd8e has led to a change C:\OSGeo4W\opt\grass\grass80.bat -> C:\OSGeo4W\opt\grass\grass81.bat. |
|
I have tested it with the freshly compiled G81, An (unrelated?) slighlty confusing message occurs with the multi-addons: But perhaps that's for a separate PR. |
It is just a warning message not bug in this case (I will try to explain below, which is justified there) and it is not related to this PR. Multi-addons e.g. i.sentinel contains multiple individual addons. Every individual addons i.sentinel.coverage, i.sentinel.download, But root addon directory i.sentinel doesn't have Python/C source file (module), contain only root addon manual html page, which is installed and therefore users will see this warning message. |
neteler
approved these changes
Jan 13, 2022
tmszi
added a commit
to tmszi/grass
that referenced
this pull request
Jan 14, 2022
When reinstalled addon is multi-addon e.g. wx.metadata which contains multiple individual addons e.g. g.gui.cswbrowser and etc. for every single addons is returned wx.metadata multi-addon name, to avoid install individual addons which isn't possible and causes an error. For finding correct muli-addon name is using modules.xml file, which have to exists on the osgeo server for download.
tmszi
added a commit
to tmszi/grass
that referenced
this pull request
Jan 14, 2022
When reinstalled addon is multi-addon e.g. wx.metadata which contains multiple individual addons e.g. g.gui.cswbrowser and etc. for every single addons is returned wx.metadata multi-addon name, to avoid install individual addons which isn't possible and causes an error. For finding correct muli-addon name is using modules.xml file, which have to exists on the osgeo server for download.
tmszi
deleted the
g_extension_all-fix-reinstallation-of-complex-addons
branch
wenzeslaus
changed the title
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Oct 26, 2022
When reinstalled addon is multi-addon e.g. wx.metadata which contains multiple individual addons e.g. g.gui.cswbrowser and etc. for every single addons is returned wx.metadata multi-addon name, to avoid install individual addons which isn't possible and causes an error. For finding correct muli-addon name is using modules.xml file, which have to exists on the osgeo server for download.
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Feb 17, 2023
When reinstalled addon is multi-addon e.g. wx.metadata which contains multiple individual addons e.g. g.gui.cswbrowser and etc. for every single addons is returned wx.metadata multi-addon name, to avoid install individual addons which isn't possible and causes an error. For finding correct muli-addon name is using modules.xml file, which have to exists on the osgeo server for download.
neteler
pushed a commit
to nilason/grass
that referenced
this pull request
Nov 7, 2023
When reinstalled addon is multi-addon e.g. wx.metadata which contains multiple individual addons e.g. g.gui.cswbrowser and etc. for every single addons is returned wx.metadata multi-addon name, to avoid install individual addons which isn't possible and causes an error. For finding correct muli-addon name is using modules.xml file, which have to exists on the osgeo server for download.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the bug
Reinstall multi-addon e.g. wx.metadata (which contains multiple individual modules), doesn't work.
To Reproduce
Steps to reproduce the behavior:
g.extension wx.metadatag.extension.all -fExpected behavior
Reinstall multi-addon e.g. wx.metadata (which contains multiple individual modules), should be work.
System description:
Additional context
Affected is reinstallation of the multi-addons (which contains multiple individual modules) e.g. wx.metadata, r.connectivity etc.