-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grass_dbmidriver: Fix pointer-sign compiler warnings for ODBC driver #2086
Conversation
BTW, do you have access to Security > Code scanning alerts?
Also, feel free to enable more checks in the gcc.yml workflow or add a Clang one (marking enabled warnings as error to prevent introduction of new ones). |
Yes, there’s some work waiting there… :)
It’s on my todo list. 👍 |
ce90d57
to
9753ca2
Compare
So, with latest push: no more compiler warnings on Travis! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 Thank you.
Many these are clear, just the right type is needed. The SQLCHAR signed/unsigned char issues seems to be solved by casts to whatever is needed in other projects, too (PHP, unixODBC), although some discussion in Postgres seems to argue for more caution, but for ODBC it says:
We're bound to need some casts, because the ODBC API tends to use
unsigned char pointers while all the libc string functions use signed.
php/php-src@aa58db7
lurcher/unixODBC@78fb6bc
https://postgrespro.com/list/thread-id/1985760
Just happened to see a bunch of
-Wpointer-sign
compiler warnings on the CI Travis Clang build log.I guess nothing critical, but good to fix.