-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manual pages: Remove unneeded SVN Date entry and selected cleanup #2143
Conversation
- remove already commented and unneeded SVN Date entries from all manual relate pages - selectively update section order to follow https://trac.osgeo.org/grass/wiki/Submitting/Docs#HTMLPages See discussion in OSGeo/grass-addons#684 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, quite an extensive cleanup beyond "search and replace". It took me some time just to scroll through the changes to check nothing came in accidentally...
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this effort to clean and homogenize manual pages :)
I mostly found extra spaces or missing spaces here and there
Co-authored-by: Veronica Andreo <veroandreo@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
* Addon manual pages: remove unneeded SVN Date entry - remove already commented and unneeded SVN Date entries from all manual relate pages - selectively update section order to follow https://trac.osgeo.org/grass/wiki/Submitting/Docs#HTMLPages Note: This change brings in the disadvantage that *all* manual pages are touched in terms of editing date, which influences the recent PR OSGeo/grass#2100 and the `g.citation` efforts ongoing in #677. On the other hand, it needs to be done one day... See - discussion in #684 (comment) - in GRASS-core, see OSGeo/grass#2143 Co-authored-by: Veronica Andreo <veroandreo@gmail.com>
@@ -1,4 +1,5 @@ | |||
<h2>DESCRIPTION</h2> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems it added an extra empty line here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be one empty line left somewhere and it has been added somewhere. Could you reapply that filter in the Geany editor (bulk modification) please, or we leave it like this, or we can try sed stream editor?
I have fixed those indicated by you.
This "filter" does not exist - I manually created search/replace operations in the Geany editor.
Please let's stop here, I would suggest to rather invest energy in adding missing examples rather than hunting more empty lines which are harmless. |
I agree with you! |
) - remove already commented and unneeded SVN Date entries from all manual relate pages - selectively update section order to follow https://trac.osgeo.org/grass/wiki/Submitting/Docs#HTMLPages See discussion in OSGeo/grass-addons#684 (comment) Co-authored-by: Veronica Andreo <veroandreo@gmail.com> Co-authored-by: Tomas Zigo <50632337+tmszi@users.noreply.github.com>
* Addon manual pages: remove unneeded SVN Date entry - remove already commented and unneeded SVN Date entries from all manual relate pages - selectively update section order to follow https://trac.osgeo.org/grass/wiki/Submitting/Docs#HTMLPages Note: This change brings in the disadvantage that *all* manual pages are touched in terms of editing date, which influences the recent PR OSGeo/grass#2100 and the `g.citation` efforts ongoing in OSGeo#677. On the other hand, it needs to be done one day... See - discussion in OSGeo#684 (comment) - in GRASS-core, see OSGeo/grass#2143 Co-authored-by: Veronica Andreo <veroandreo@gmail.com>
…Geo#2143) - remove already commented and unneeded SVN Date entries from all manual relate pages - selectively update section order to follow https://trac.osgeo.org/grass/wiki/Submitting/Docs#HTMLPages See discussion in OSGeo/grass-addons#684 (comment) Co-authored-by: Veronica Andreo <veroandreo@gmail.com> Co-authored-by: Tomas Zigo <50632337+tmszi@users.noreply.github.com>
…Geo#2143) - remove already commented and unneeded SVN Date entries from all manual relate pages - selectively update section order to follow https://trac.osgeo.org/grass/wiki/Submitting/Docs#HTMLPages See discussion in OSGeo/grass-addons#684 (comment) Co-authored-by: Veronica Andreo <veroandreo@gmail.com> Co-authored-by: Tomas Zigo <50632337+tmszi@users.noreply.github.com>
…Geo#2143) - remove already commented and unneeded SVN Date entries from all manual relate pages - selectively update section order to follow https://trac.osgeo.org/grass/wiki/Submitting/Docs#HTMLPages See discussion in OSGeo/grass-addons#684 (comment) Co-authored-by: Veronica Andreo <veroandreo@gmail.com> Co-authored-by: Tomas Zigo <50632337+tmszi@users.noreply.github.com>
Note: This change brings in the disadvantage that all manual pages are touched in terms of editing date, which influences the recent PR #2100 and the
g.citation
efforts ongoing in OSGeo/grass-addons#677. On the other hand, it needs to be done one day...See discussion in OSGeo/grass-addons#684 (comment)