Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i.atcorr: Replace CRLF by LF in sensor CSVs #2149

Merged
merged 1 commit into from
Feb 4, 2022

Conversation

wenzeslaus
Copy link
Member

This repleaces CRLF (dos) by LF (unix) line ending in geoeye1 and sentinel_2A_msi CSV files. See also #2144 and #2147.

This repleaces CRLF (dos) by LF (unix) line ending in geoeye1 and sentinel_2A_msi CSV files. See also OSGeo#2144 and OSGeo#2147.
@wenzeslaus wenzeslaus added this to the 8.2.0 milestone Feb 1, 2022
@wenzeslaus
Copy link
Member Author

Can someone please review these changes in i.atcorr files? The CSV files seem unused, but I don't see documentation for it, so I would like to confirm that there is not anything special about them.

@BadAssassin
Copy link
Contributor

BadAssassin commented Feb 1, 2022 via email

@neteler
Copy link
Member

neteler commented Feb 1, 2022

The CSV files seem unused, but I don't see documentation for it,

The sensor-specific CSV files are the input to reconstruct the CPP source code via create_iwave.py and should be kept:

Basically it needs a .csv file with spectral response for each

@wenzeslaus
Copy link
Member Author

I have tested the script with the geoeye1.csv file and it gives same result as what is currently in the .cpp file. The documentation for this is in the parent directory in a README file which I overlooked before that (there is a separate README file just for the CSV files in the CSV directory).

@wenzeslaus wenzeslaus merged commit 8dea4ec into OSGeo:main Feb 4, 2022
@wenzeslaus wenzeslaus deleted the fix-eol-i_atcorr branch February 4, 2022 22:13
@wenzeslaus wenzeslaus added the enhancement New feature or request label Feb 4, 2022
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
This replaces CRLF (dos) by LF (unix) line ending in geoeye1 and sentinel_2A_msi CSV files. See also OSGeo#2144 and OSGeo#2147.
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
This replaces CRLF (dos) by LF (unix) line ending in geoeye1 and sentinel_2A_msi CSV files. See also OSGeo#2144 and OSGeo#2147.
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
This replaces CRLF (dos) by LF (unix) line ending in geoeye1 and sentinel_2A_msi CSV files. See also OSGeo#2144 and OSGeo#2147.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants