Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checks: Fix -Wuninitialized compiler warnings #2164

Merged
merged 4 commits into from
Nov 9, 2022

Conversation

nilason
Copy link
Contributor

@nilason nilason commented Feb 4, 2022

As reported in #2156.

Initially this is a draft, I commented in code to highlight the uninitialised variables.
We need to decide how to address them.

Affects:

Modules

  • i.gensig
  • r.statistics
  • r.stream.extract
  • v.lrs.label
  • v.net.salesman
  • v.split

GRASS Library parts

  • lib/cdhc
  • lib/raster
  • lib/raster3d
  • lib/rst/interp_float
  • lib/vector/neta
  • lib/vector/Vlib

@nilason nilason mentioned this pull request Feb 4, 2022
21 tasks
@nilason nilason added this to the 8.2.0 milestone Feb 4, 2022
@nilason nilason added C Related code is in C enhancement New feature or request labels Feb 4, 2022
imagery/i.gensig/means.c Outdated Show resolved Hide resolved
@nilason nilason modified the milestones: 8.2.0, 8.4.0 Mar 17, 2022
@nilason
Copy link
Contributor Author

nilason commented Oct 28, 2022

Rebased, good to (re-)start...

@nilason nilason marked this pull request as ready for review November 4, 2022 15:52
@nilason
Copy link
Contributor Author

nilason commented Nov 4, 2022

Opening for review. Comments are left for the time being for context. They will be removed before merge.

lib/cdhc/enormp.c Outdated Show resolved Hide resolved
vector/v.net.salesman/main.c Outdated Show resolved Hide resolved
lib/cdhc/enormp.c Outdated Show resolved Hide resolved
@nilason
Copy link
Contributor Author

nilason commented Nov 9, 2022

Just somewhat related question:
Do you think it could be of interest to add
cdh.f.txt

retrieved from the Internet Archive for http://sunsite.univie.ac.at/statlib/general/cdh

to the lib/cdhc/doc directory ?

@wenzeslaus
Copy link
Member

....add cdh.f.txt...to the lib/cdhc/doc directory?

Maybe as Markdown file with a code block rather than a text file with a strange extension and content?

@nilason
Copy link
Contributor Author

nilason commented Nov 9, 2022

Well, now I think this is good to go.

@nilason nilason merged commit cd43296 into OSGeo:main Nov 9, 2022
@nilason
Copy link
Contributor Author

nilason commented Nov 9, 2022

Thank you all for the feedback!

@nilason nilason deleted the fix_wall_warnings_08 branch November 9, 2022 22:35
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
marisn pushed a commit to marisn/grass that referenced this pull request Jun 2, 2023
@neteler neteler changed the title Fix -Wuninitialized compiler warnings checks: Fix -Wuninitialized compiler warnings Jun 6, 2023
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C Related code is in C enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants