Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contributors.csv: added new ORCID column #2177

Merged
merged 4 commits into from
Feb 13, 2022
Merged

contributors.csv: added new ORCID column #2177

merged 4 commits into from
Feb 13, 2022

Conversation

neteler
Copy link
Member

@neteler neteler commented Feb 6, 2022

This PR adds a new orcid column (https://orcid.org/) to the file for better citation of authors.
For discussion, see https://lists.osgeo.org/pipermail/grass-psc/2022-January/002531.html

I have made a quick round of searches to identify some ORCIDs. Please review.

This PR adds a new `orcid` column (https://orcid.org/) to the file for better citation of authors.
For discussion, see https://lists.osgeo.org/pipermail/grass-psc/2022-January/002531.html

I have made a quick round of searches to identify some ORCIDs. Please review.
@neteler neteler added enhancement New feature or request manual Documentation related issues labels Feb 6, 2022
@neteler neteler added this to the 8.2.0 milestone Feb 6, 2022
@neteler
Copy link
Member Author

neteler commented Feb 6, 2022

Do we need a change in gui/wxpython/gui_core/ghelp.py to take care of the new column?

@neteler neteler added the help wanted Extra attention is needed label Feb 6, 2022
@lucadelu
Copy link
Contributor

lucadelu commented Feb 6, 2022

Thanks Markus, mine is fine

@tmszi
Copy link
Member

tmszi commented Feb 8, 2022

Do we need a change in gui/wxpython/gui_core/ghelp.py to take care of the new column?

Yes we do, patches.zip. The contributors.csv file required changes sed -e 's/,-$/,-,-/g' -e 's/yes,$/yes,-/g' -i contributors.csv.

@neteler
Copy link
Member Author

neteler commented Feb 8, 2022

Yes we do, patches.zip. The contributors.csv file required changes sed -e 's/,-$/,-,-/g' -e 's/yes,$/yes,-/g' -i contributors.csv.

Thanks so much, @tmszi - added to this PR.

@neteler neteler requested a review from tmszi February 12, 2022 15:29
Copy link
Member

@tmszi tmszi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as expected (compiled, and tested).

wxgui_about_gg_contributors

@neteler neteler merged commit 3460a60 into OSGeo:main Feb 13, 2022
@neteler neteler deleted the contributors_orcid branch February 13, 2022 12:58
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
* contributors.csv: added new ORCID column
* wxGUI: orcid column support added, contributed by @tmszi

This PR adds a new `orcid` column (https://orcid.org/) to the file for better citation of authors.
For discussion, see https://lists.osgeo.org/pipermail/grass-psc/2022-January/002531.html

Co-authored-by: Tomas Zigo <tomas.zigo@slovanet.sk>
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
* contributors.csv: added new ORCID column
* wxGUI: orcid column support added, contributed by @tmszi

This PR adds a new `orcid` column (https://orcid.org/) to the file for better citation of authors.
For discussion, see https://lists.osgeo.org/pipermail/grass-psc/2022-January/002531.html

Co-authored-by: Tomas Zigo <tomas.zigo@slovanet.sk>
neteler added a commit to nilason/grass that referenced this pull request Nov 7, 2023
* contributors.csv: added new ORCID column
* wxGUI: orcid column support added, contributed by @tmszi

This PR adds a new `orcid` column (https://orcid.org/) to the file for better citation of authors.
For discussion, see https://lists.osgeo.org/pipermail/grass-psc/2022-January/002531.html

Co-authored-by: Tomas Zigo <tomas.zigo@slovanet.sk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed manual Documentation related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants