Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

winGRASS: Add missing DLLs for MS Windows packaging #2204

Merged
merged 1 commit into from
Feb 14, 2022
Merged

winGRASS: Add missing DLLs for MS Windows packaging #2204

merged 1 commit into from
Feb 14, 2022

Conversation

ninsbl
Copy link
Member

@ninsbl ninsbl commented Feb 13, 2022

Fix #2197

Co-authored-by: Helmut Kudrnovsky hellik@web.de

@ninsbl ninsbl added bug Something isn't working windows Microsoft Windows specific labels Feb 13, 2022
@ninsbl ninsbl added this to the 8.0.1 milestone Feb 13, 2022
hellik
hellik approved these changes Feb 13, 2022
View reviewed changes
Copy link
Member

@hellik hellik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking over the PR.

@ninsbl
Copy link
Member Author

ninsbl commented Feb 14, 2022

Test failures are unrelated. Merging this now.
A bit unsure when to backport (before or after 8.0.1). As @hellik points out on ML, this is mainly a packaging issue that will not affect other OS than MS Windows. And the change is minimal and relevant test passes. However we may wait with backporting until changes are practically tested on a daily build of the development branch where related code should be identical...
Important that this get`s tested outside github actions, where the dlls are available by default...

@ninsbl ninsbl merged commit 324782e into OSGeo:main Feb 14, 2022
@neteler neteler mentioned this pull request Feb 18, 2022
Closed
@hellik
Copy link
Member

hellik commented Feb 18, 2022

@landam could you please have also a look at #2197 comment

ninsbl added a commit to ninsbl/grass that referenced this pull request Feb 18, 2022
@ninsbl
MS Windows packaging: add missing dlls from MSYS (OSGeo#2204)
3065243
@ninsbl ninsbl mentioned this pull request Feb 18, 2022
Merged
@hellik hellik mentioned this pull request Feb 20, 2022
Closed
ninsbl added a commit that referenced this pull request Feb 20, 2022
@ninsbl
MS Windows packaging: add missing dlls from MSYS (#2204) (#2223)
410fde0
@wenzeslaus wenzeslaus changed the title MS Windows packaging: add missing dlls winGRASS: Add missing DLLs for MS Windows packaging Apr 27, 2022
ninsbl added a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
@ninsbl
MS Windows packaging: add missing dlls from MSYS (OSGeo#2204)
670b930
ninsbl added a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
@ninsbl
MS Windows packaging: add missing dlls from MSYS (OSGeo#2204)
34dcc3b
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
@ninsbl @neteler
MS Windows packaging: add missing dlls from MSYS (OSGeo#2204)
ecb09ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellik hellik hellik approved these changes

Assignees
No one assigned
Labels
bug Something isn't working windows Microsoft Windows specific
Projects
None yet
Milestone
8.0.1
Development

Successfully merging this pull request may close these issues.

[Bug] winGRASS is missing: libgomp-1.dll, libgfortran-5.dll, libquadmath-0.dll
3 participants
@ninsbl @hellik @nilason