-
-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wxGUI Single-Window: Make Tools pane wider after startup #2216
wxGUI Single-Window: Make Tools pane wider after startup #2216
Conversation
What about #2210, could you try to address it here? It seems related. |
Well, I have already kind of addressed it (without noticing @veroandreo 's Issue, good to see it now). I also looked at the small arrow which appears in Data Catalog toolbar when shrinked "too much". I remember that the arrow was not appearing but I think that the problem was in Search box. Now when Search box is no longer the part of toolbar, it fixed itself. |
I changed milestone to 8.2 as this lives only in main so far, right? |
@veroandreo does this address #2210? I am thinking they could be shrinked even more, but no strong opinion. |
Oh sure, the previous plan :-) I switched 0 and 2 by mistake. |
I have tried one eighth of display size as a minimum pane size. It looks as follows: probably better, I would go with this. What do you think? |
Yes! I like this one better! For more space, as you said earlier, the user can directly minimize. |
This doesn't seem to differ a lot from the original state. I would make the right pane wider because often one of the first things I do is to resize it. Also when I tested it looks like the right pane doesn't have a minimal width, while the left does, was that the intention? I don't have a strong opinion whether they should be both the same width, although I think it would make things simpler. Ultimately I think the layout should be saved in settings (out of scope of this PR). |
We can make the size of both panes the same, I do not have a strong opinion either. The minimum size could be also set up. There is just a little problem that you actually set up the minimum size only for this particular "startup" notebook but when a user creates a different notebook the minimum size is not applied. |
And set min size smaller, fixes OSGeo#2210.
And set min size smaller, fixes OSGeo#2210.
And set min size smaller, fixes OSGeo#2210.
Before:
After:
The width is the same for both side panels.