Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: update to latest config.guess and config.sub #2225

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

nilason
Copy link
Contributor

@nilason nilason commented Feb 20, 2022

This updates to latest config.guess and config.sub. Not much of a change, but doesn't hurt to update this regularly.

@nilason
Copy link
Contributor Author

nilason commented Feb 20, 2022

Should be backported to 8.0 and 7.8 branch.

@neteler neteler added this to the 8.0.2 milestone Feb 20, 2022
@neteler
Copy link
Member

neteler commented Feb 20, 2022

This usually happens pre RC1:
https://github.com/OSGeo/grass/blob/main/doc/howto_release.md#update-of-configure-base-files

I had considered it then skipped it - if we go for a 8.0.1RC2 then it could be backported but if not urgent I'd prefer 8.0.2 and 7.8.8.

Copy link
Member

@neteler neteler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nilason
Copy link
Contributor Author

nilason commented Feb 20, 2022

This usually happens pre RC1: https://github.com/OSGeo/grass/blob/main/doc/howto_release.md#update-of-configure-base-files

I had considered it then skipped it - if we go for a 8.0.1RC2 then it could be backported but if not urgent I'd prefer 8.0.2 and 7.8.8.

Perfectly fine for me, not at all urgent.

@nilason
Copy link
Contributor Author

nilason commented Feb 20, 2022

The autoconf2.69 step is missing, see
https://github.com/OSGeo/grass/blob/main/doc/howto_release.md#update-of-configure-base-files

I'm not quite sure what you mean, running autoconf doesn't make any difference.

@neteler
Copy link
Member

neteler commented Feb 20, 2022

I'm not quite sure what you mean, running autoconf doesn't make any difference.

I see - mostly it does but apparently it doesn't affect configure in this case. Sorry for the confusion.

@neteler neteler dismissed their stale review February 20, 2022 14:38

configure is not affected by running autoconf2.69

@nilason
Copy link
Contributor Author

nilason commented Feb 20, 2022

I'm not quite sure what you mean, running autoconf doesn't make any difference.

I see - mostly it does but apparently it doesn't affect configure in this case. Sorry for the confusion.

No worries :-) As far as I understand it, the config.guess and config.sub are read/run by configure, but not altering the configure file.

@neteler
Copy link
Member

neteler commented Feb 20, 2022

Looking at the history of configure it appears that sometimes also this file is affected (e.g., d57f409, 1774674,
fcffbb5), i.e. to be updated with autoconf.

@nilason
Copy link
Contributor Author

nilason commented Feb 20, 2022

Looking at the history of configure it appears that sometimes also this file is affected (e.g., d57f409, 1774674,
fcffbb5), i.e. to be updated with autoconf.

Non of those changes to configure are caused by updating config.guess or config.sub.
The first two are patches (the same applied twice) to autoconf 2.13:

for ac_declaration in \
    ''\
    '#include <stdlib.h>' \
    'extern "C" void std::exit (int) throw (); using std::exit;' \
    'extern "C" void std::exit (int); using std::exit;' \
    'extern "C" void exit (int) throw ();' \
    'extern "C" void exit (int);' \
    'void exit (int);'
 do
...

(see eg. https://git.rockylinux.org/staging/rpms/autoconf213/-/blob/r8/SOURCES/autoconf-2.13-c++exit.patch or https://bugzilla.redhat.com/show_bug.cgi?id=18829)

The third is a caused by a previous change in aclocal.m4 without updating configure.

@neteler
Copy link
Member

neteler commented Feb 20, 2022

Agreed. But just for the future procedure: shall we treat these updates (config.* vs autoconf) separately? Then the release procedure needs an update.

@nilason
Copy link
Contributor Author

nilason commented Feb 20, 2022

Agreed. But just for the future procedure: shall we treat these updates (config.* vs autoconf) separately? Then the release procedure needs an update.

I think so, the config.* files should/may be updated before RC release.
In addition, it doesn't hurt running autoconf, to see if there are any patches, or other inconsistencies (like the above mentioned case of aclocal.m4). And if there are any patches, they should be added to configure.in too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants