Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grass.jupyter: Test init and session #2247

Merged
merged 3 commits into from
Mar 16, 2022

Conversation

wenzeslaus
Copy link
Member

@wenzeslaus wenzeslaus commented Mar 4, 2022

Adds test for init, session, and finish using pytest. Uses temporary script to test automatic (implicit) cleanup with weakref.finalize.

Depends on #2246.

@wenzeslaus wenzeslaus added the Python Related code is in Python label Mar 4, 2022
@wenzeslaus wenzeslaus added this to the 8.2.0 milestone Mar 4, 2022
@wenzeslaus
Copy link
Member Author

To clarify, this is marked as ready for review because the code is ready. The test is failing because of an unrelated issue fixed in #2246. Thus this needs #2246 to run successfully, but other than that it is ready to be merged. ...or so I thought when creating the PR.

Adds test for init, session, and finish using pytest. Uses temporary script to test automatic (implicit) cleanup with weakref.finalize.
@wenzeslaus wenzeslaus force-pushed the jupyter-session-test branch from 82948ff to afbd89a Compare March 15, 2022 21:37
@wenzeslaus wenzeslaus merged commit f9ee75c into OSGeo:main Mar 16, 2022
@wenzeslaus wenzeslaus deleted the jupyter-session-test branch March 16, 2022 02:09
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
Adds test for Jupyter init, session, and finish using pytest.

Uses temporary script to test automatic (implicit) cleanup with weakref.finalize (always needed).

Uses temporary script for the standard test because the session restores the global state cleanly, namely the global variables in the Python library (temporary solution).
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
Adds test for Jupyter init, session, and finish using pytest.

Uses temporary script to test automatic (implicit) cleanup with weakref.finalize (always needed).

Uses temporary script for the standard test because the session restores the global state cleanly, namely the global variables in the Python library (temporary solution).
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
Adds test for Jupyter init, session, and finish using pytest.

Uses temporary script to test automatic (implicit) cleanup with weakref.finalize (always needed).

Uses temporary script for the standard test because the session restores the global state cleanly, namely the global variables in the Python library (temporary solution).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Python Related code is in Python
Development

Successfully merging this pull request may close these issues.

1 participant