Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grass.jupyter: automatically determine render image dimensions based on region #2285

Merged
merged 3 commits into from
Apr 12, 2022
Merged

grass.jupyter: automatically determine render image dimensions based on region #2285

merged 3 commits into from
Apr 12, 2022

Conversation

petrasovaa
Copy link
Contributor

Old behavior:
Screenshot from 2022-03-28 23-15-48

New behavior:
Screenshot from 2022-03-28 23-11-56

@petrasovaa petrasovaa added this to the 8.2.0 milestone Mar 29, 2022
@wenzeslaus wenzeslaus added the enhancement New feature or request label Mar 29, 2022
@wenzeslaus wenzeslaus added the Python Related code is in Python label Mar 29, 2022
@petrasovaa petrasovaa requested a review from chaedri April 1, 2022 14:50
@petrasovaa
Copy link
Contributor Author

Binder test link:
https://mybinder.org/v2/gh/petrasovaa/grass/jupyter-image-aspect-ratio-region?urlpath=lab%2Ftree%2Fdoc%2Fnotebooks%2Fgrass_jupyter.ipynb

chaedri
chaedri approved these changes Apr 4, 2022
View reviewed changes
python/grass/jupyter/display.py Show resolved Hide resolved
wenzeslaus
wenzeslaus requested changes Apr 8, 2022
View reviewed changes
python/grass/jupyter/display.py Outdated Show resolved Hide resolved
python/grass/jupyter/region.py Show resolved Hide resolved
wenzeslaus
wenzeslaus approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only remaining question is is whether the adjust_rendering_size_from_region() call should be external call like this or should be handled internally, but that's a low priority task for the API PR.

@wenzeslaus wenzeslaus merged commit 389ce3a into OSGeo:main Apr 12, 2022
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
@petrasovaa @ninsbl
grass.jupyter: Automatically determine image size based on region (OS…
8c6086a 
…Geo#2285)

Using the aspect ratio of the computational region, automatically determine 2D rendered image dimensions. Defaults are now None and one or both values can be specified. Missing values are taken from defaults and modified to match aspect ratio of the computational region extent. Resulting images in notebooks are now smaller without white (empty) areas around the data. As a result, the image of the displayed data is often significantly bigger.
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
@petrasovaa @ninsbl
grass.jupyter: Automatically determine image size based on region (OS…
737218b 
…Geo#2285)

Using the aspect ratio of the computational region, automatically determine 2D rendered image dimensions. Defaults are now None and one or both values can be specified. Missing values are taken from defaults and modified to match aspect ratio of the computational region extent. Resulting images in notebooks are now smaller without white (empty) areas around the data. As a result, the image of the displayed data is often significantly bigger.
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
@petrasovaa @neteler
grass.jupyter: Automatically determine image size based on region (OS…
634349a 
…Geo#2285)

Using the aspect ratio of the computational region, automatically determine 2D rendered image dimensions. Defaults are now None and one or both values can be specified. Missing values are taken from defaults and modified to match aspect ratio of the computational region extent. Resulting images in notebooks are now smaller without white (empty) areas around the data. As a result, the image of the displayed data is often significantly bigger.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenzeslaus wenzeslaus wenzeslaus approved these changes

@chaedri chaedri chaedri approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Python Related code is in Python
Projects
Integration with Jupyter Notebooks
Status: Done
Milestone
8.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@petrasovaa @wenzeslaus @chaedri