d.graph: Remove an always true condition #2296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenzeslaus
approved these changes
Apr 7, 2022
wenzeslaus
changed the title
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Oct 26, 2022
The function returns if `num < coors_allocated` and since `to_alloc` is assigned with `coors_allocated`, the removed condition is always true and thus useless. So, we can directly assign `to_alloc` with `num + CHUNK`.
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Feb 17, 2023
The function returns if `num < coors_allocated` and since `to_alloc` is assigned with `coors_allocated`, the removed condition is always true and thus useless. So, we can directly assign `to_alloc` with `num + CHUNK`.
neteler
pushed a commit
to nilason/grass
that referenced
this pull request
Nov 7, 2023
The function returns if `num < coors_allocated` and since `to_alloc` is assigned with `coors_allocated`, the removed condition is always true and thus useless. So, we can directly assign `to_alloc` with `num + CHUNK`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allocreturns 0 ifnum < coors_allocatedsince to_alloc is assigned withcoors_allocated, the condition is always true. So, we can directly assignto_allocwithnum + CHUNK