r.stats.quantile: sync to r.quantile #2323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metzm
added
bug
wenzeslaus
approved these changes
Apr 26, 2022
There was a problem hiding this comment.
This fixes the issue. I don't get the Invalid read reported in #2259 with valgrind r.stats.quantile base=zipcodes cover=elevation quantiles=3 -p anymore (I do without this PR).
I get Conditional jump or move depends on uninitialised value(s) from quant_parse_file which I get even with 9317110 which is before #2108.
|
BTW: The new minimalistic testsuite added in #2325 should be sufficient to see the segfault being fixed. |
neteler
pushed a commit
that referenced
this pull request
Apr 26, 2022
* sync correctly to r.quantile * fix segfault Fixes #2259
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Oct 26, 2022
* sync correctly to r.quantile * fix segfault Fixes OSGeo#2259
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Feb 17, 2023
* sync correctly to r.quantile * fix segfault Fixes OSGeo#2259
neteler
pushed a commit
to nilason/grass
that referenced
this pull request
Nov 7, 2023
* sync correctly to r.quantile * fix segfault Fixes OSGeo#2259
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2259