-
-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grass.jupyter: fix resolution handling for InteractiveMap #2376
Conversation
I have tested this with my larger dataset: Then, when displaying it. I get: Checking in parallel what is run underneath, with
What I notice is that I set the computational region to |
Try use_region=True |
Ok, this then changes the resolution (not sure how to inspect the bbox):
And it helps: The question is now what should be the default: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added grammar suggestions in the documentation paragraph :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code and behavior make sense to me.
Co-authored-by: Veronica Andreo <veroandreo@gmail.com>
Should address #2369. Now when use_region=True or saved_region, it should reproject the map with the correct resolution. Note that in these cases the resolution is not estimated by r.proj but is estimated by reprojecting the extent and using the same ncols/nrows as in the source region, which might not be the most precise way.