g.region: fix setting from default region #2397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenzeslaus
approved these changes
May 25, 2022
There was a problem hiding this comment.
The behavior after the fix seems correct given that -d Set from default region.
The test covers the base line use without -d, standard usage of -d, and its more advanced combination without update for printing only. Some standard usage of g.region is indirectly tested by many of the other tests.
I vote for backport to 8.2 branch so that it goes into 8.2.0.
petrasovaa
added a commit
that referenced
this pull request
May 26, 2022
petrasovaa
added a commit
that referenced
this pull request
May 26, 2022
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Oct 26, 2022
Fix after g.region was broken with OSGeo#1627 (78d902d). Added test for d flag.
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Feb 17, 2023
Fix after g.region was broken with OSGeo#1627 (78d902d). Added test for d flag.
neteler
pushed a commit
to nilason/grass
that referenced
this pull request
Nov 7, 2023
Fix after g.region was broken with OSGeo#1627 (78d902d). Added test for d flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like #1627 broke
g.region -dso this should fix it.As a workaround,
g.region -dowill do it.Not sure about the milestone, too late for 8.2?
Needs to be backported in 8.0 too.