Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxGUI/dbmgr: show warning message dialog if new layer table link exists #2428

Merged

Conversation

tmszi
Copy link
Member

@tmszi tmszi commented Jun 12, 2022

Describe the bug
If layer table link exist, no warning message dialog is showed (Attribute table link exists), and Layer SpinCtrl widget (on the Manage layers page (tab)) increase value automatically.

To Reproduce
Steps to reproduce the behavior:

  1. Launch Attribute Table Manager e.g g.gui.dbmgr geology
  2. Switch to Manage layers page (tab)
  3. From Table choice widget choose geology table
  4. Hit Add layer button
  5. Layer SpinCtrl widget automatically increase value (number 3), no warning message dialog is showed with message Attribute table link exists

Expected behavior
If layer table link exist, warning message dialog should be showed, and Layer SpinCtrl widget (on the Manage layers page (tab)) value should be not increased too.

wxgui_dbmgr_layer_table_link_exists_exp

System description (please complete the following information):

  • Operating System: all
  • GRASS GIS version: all

@tmszi tmszi added bug Something isn't working backport_needed GUI wxGUI related labels Jun 12, 2022
@tmszi tmszi added this to the 8.2.1 milestone Jun 12, 2022
Copy link
Contributor

@petrasovaa petrasovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, although I haven't tested it.

@tmszi tmszi merged commit 2af9d79 into OSGeo:main Jun 20, 2022
tmszi added a commit to tmszi/grass that referenced this pull request Jun 20, 2022
tmszi added a commit to tmszi/grass that referenced this pull request Jun 20, 2022
tmszi added a commit to tmszi/grass that referenced this pull request Jun 20, 2022
@tmszi tmszi deleted the wxgui_dbmgr_show_warn_mess_dial_if_layer_table_exist branch June 20, 2022 03:39
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working GUI wxGUI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants