Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxGUI/dbmgr: don't add new duplicated table col into table desc TableListCtrl widget #2437

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

tmszi
Copy link
Member

@tmszi tmszi commented Jun 15, 2022

Describe the bug
Duplicated column name be added into table description TableListCtrl widget (see screenshot below).

To Reproduce
Steps to reproduce the behavior:

  1. Launch Attribute Table Manager e.g g.gui.dbmgr geology
  2. Switch to Manage tables page (tab)
  3. Add new column with same name as existed col name GEO_NAME
  4. You see correct error dialog with message: Column <GEO_NAME> already exists in table .
  5. Duplicated column name is added into table description TableListCtrl widget

wxgui_dbmgr_add_duplicated_col_name_def

Expected behavior
Duplicated column name shouldn't be added into table description TableListCtrl widget

System description (please complete the following information):

  • Operating System: all
  • GRASS GIS version: all

@tmszi tmszi added bug Something isn't working backport_needed GUI wxGUI related labels Jun 15, 2022
@tmszi tmszi added this to the 8.2.1 milestone Jun 15, 2022
@neteler neteler modified the milestones: 8.2.1, 8.2.2 Jan 22, 2023
@wenzeslaus wenzeslaus modified the milestones: 8.2.2, 8.3.1 Jun 6, 2023
@tmszi tmszi force-pushed the wxgui_dbmgr_fix_add_duplicated_col_name branch from e60b4f3 to c7a0912 Compare September 12, 2023 06:35
@tmszi
Copy link
Member Author

tmszi commented Sep 12, 2023

Rebase c7a0912.

@tmszi tmszi merged commit d4ffbf8 into OSGeo:main Sep 12, 2023
18 checks passed
tmszi added a commit to tmszi/grass that referenced this pull request Sep 12, 2023
tmszi added a commit to tmszi/grass that referenced this pull request Sep 12, 2023
@tmszi tmszi deleted the wxgui_dbmgr_fix_add_duplicated_col_name branch September 12, 2023 11:16
landam pushed a commit to landam/grass that referenced this pull request Oct 25, 2023
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working GUI wxGUI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants