Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wxGUI/dbmgr: update Browse data page Simple SQL Query WHERE ComboBox widget column names choices #2438

Merged
merged 5 commits into from
Sep 28, 2023
Merged

wxGUI/dbmgr: update Browse data page Simple SQL Query WHERE ComboBox widget column names choices #2438

merged 5 commits into from
Sep 28, 2023

Conversation

tmszi
Copy link
Member

@tmszi tmszi commented Jun 15, 2022 •
edited
Loading

Describe the bug
When you add new table column or rename existed or delete, Browse data page Simple SQL Query WHERE ComboBox widget column names choices doesn't update. Same for SQL Builder frame (must be opened before added/renamed/deleted table column) ListBox widget table column names choices. Same for Field Calculator (must be opened before added/renamed/deleted table column) ListBox widget table column names choices.

To Reproduce
Steps to reproduce the behavior:

  1. Launch Attribute Table Manager e.g g.gui.dbmgr geology
  2. Switch to Manage tables page (tab)
  3. Add new column e.g. test with double precision type or rename existed column e.g. PERIMETER -> PERIMETER_NEW or delete some existed table column e.g. PERIMETER
  4. Switch to Browse data page (tab)
  5. Check Simple SQL Query WHERE ComboBox widget column names choices
  6. Newly added table column test or renamed column PERIMETER_NEW or deleted column PERIMETER is missing from ComboBox widget choices

Screenshots

wxgui_dbmgr_browse_data_page_simple_sql_query_where_combobox_widget_column_names_choices_def

or

  1. On the Browse data page (tab) swich to Builder page (tab) and hit SQL Builder button to open SQL Builder frame
  2. On The Attribute Table Manager frame switch to Manage tables page (tab)
  3. Add new column e.g. test with double precision type or rename existed column e.g. PERIMETER -> PERIMETER_NEW or delete some existed table column e.g. PERIMETER
  4. Switch to opened SQL Builder frame and check ListBox widget table column names choices
  5. Newly added table column test or renamed column PERIMETER_NEW is missing from ListBox widget choices. Deleted column PERIMETER is still present in widget choices.

wxgui_dbmgr_browse_data_page_sql_builder_listbox_widget_column_names_choices_def

or

  1. On the Browse data page (tab) right mouse click on the e.g. PERIMETER column to invoke menu and choose Field Calculator item
  2. On The Attribute Table Manager frame switch to Manage tables page (tab)
  3. Add new column e.g. test with double precision type or rename existed column e.g. PERIMETER -> PERIMETER_NEW or delete some existed table column e.g. PERIMETER
  4. Switch to opened Field Calculator frame and check ListBox widget table column names choices
  5. Newly added table column test or renamed column PERIMETER_NEW is missing from ListBox widget choices. Deleted column PERIMETER is still present in widget choices.

wxgui_dbmgr_browse_data_page_field_calc_listbox_widget_column_names_choices_def

Expected behavior
When you add new table column or rename existed or deleted, Browse data page Simple SQL Query WHERE ComboBox widget column names choices should be updated. If you have opened SQL Builder frame ListBox widget table column names choices should be updated too. If you have opened Field calculator frame ListBox widget table column names choices should be updated too.

System description (please complete the following information):

  • Operating System: all
  • GRASS GIS version: all

@tmszi tmszi added bug Something isn't working backport_needed GUI wxGUI related labels Jun 15, 2022
@tmszi tmszi added this to the 8.2.1 milestone Jun 15, 2022
@neteler neteler modified the milestones: 8.2.1, 8.2.2 Jan 22, 2023
@wenzeslaus wenzeslaus modified the milestones: 8.2.2, 8.3.1 Jun 6, 2023
@tmszi
wxGUI/dbmgr: update Browse data page Simple SQL Query WHERE ComboBox …
1af4edd 
…widget column names choices

If new table column was added or renamed.
@tmszi
wxGUI/dbmgr: update Browse data page SQL Builder column names ListBox…
4cabcbd 
… widget column names choices

If new table column was added or renamed.
@tmszi
wxGUI/dbmgr: update Browse data page Simple SQL Query WHERE ComboBox …
f64fc9e 
…widget column names choices and SQL Builder column names ListBox widget choices

If table column was deleted.
@tmszi
wxGUI/dbmgr: fix update Browse data page Simple SQL Query WHERE Comb…
6fe6638 
…oBox widget column names choices and SQL Builder column names ListBox widget choices

If all table columns was deleted.
@tmszi
wxGUI/dbmgr: fix update Browse data page column field calculator colu…
70d3502 
…mn names ListBox widget choices

If new table column was added, renamed, deleted or
deleted all columns.
@tmszi tmszi force-pushed the wxgui_dbmgr_update_browse_data_page_simple_where_cols branch from 8c17b8d to 70d3502 Compare September 27, 2023 06:57
@tmszi
Copy link
Member Author

tmszi commented Sep 27, 2023

Rebase 70d3502.

@tmszi tmszi merged commit b60356c into OSGeo:main Sep 28, 2023
tmszi added a commit to tmszi/grass that referenced this pull request Sep 28, 2023
@tmszi
wxGUI/dbmgr: update Browse data page Simple SQL Query WHERE ComboBox …
b989e81 
…widget column names choices (OSGeo#2438)

* update Browse data page SQL Builder column names
ListBox widget column names choices

* update Browse data page column field calculator
column names ListBox widget choices

If new table column was added, renamed, deleted or
deleted are all columns.
tmszi added a commit to tmszi/grass that referenced this pull request Sep 28, 2023
@tmszi
wxGUI/dbmgr: update Browse data page Simple SQL Query WHERE ComboBox …
b6e25e4 
…widget column names choices (OSGeo#2438)

* update Browse data page SQL Builder column names
ListBox widget column names choices

* update Browse data page column field calculator
column names ListBox widget choices

If new table column was added, renamed, deleted or
deleted are all columns.
@tmszi tmszi deleted the wxgui_dbmgr_update_browse_data_page_simple_where_cols branch September 28, 2023 18:34
landam pushed a commit to landam/grass that referenced this pull request Oct 25, 2023
@tmszi @landam
wxGUI/dbmgr: update Browse data page Simple SQL Query WHERE ComboBox …
421d566 
…widget column names choices (OSGeo#2438)

* update Browse data page SQL Builder column names
ListBox widget column names choices

* update Browse data page column field calculator
column names ListBox widget choices

If new table column was added, renamed, deleted or
deleted are all columns.
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
@tmszi @neteler
wxGUI/dbmgr: update Browse data page Simple SQL Query WHERE ComboBox …
ce6a216 
…widget column names choices (OSGeo#2438)

* update Browse data page SQL Builder column names
ListBox widget column names choices

* update Browse data page column field calculator
column names ListBox widget choices

If new table column was added, renamed, deleted or
deleted are all columns.
HuidaeCho pushed a commit to HuidaeCho/grass that referenced this pull request Jan 9, 2024
@tmszi @HuidaeCho
wxGUI/dbmgr: update Browse data page Simple SQL Query WHERE ComboBox …
70082ef 
…widget column names choices (OSGeo#2438)

* update Browse data page SQL Builder column names
ListBox widget column names choices

* update Browse data page column field calculator
column names ListBox widget choices

If new table column was added, renamed, deleted or
deleted are all columns.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrasovaa petrasovaa petrasovaa approved these changes

Assignees
No one assigned
Labels
bug Something isn't working GUI wxGUI related
Projects
None yet
Milestone
8.3.1
Development

Successfully merging this pull request may close these issues.
5 participants
@tmszi @petrasovaa @neteler @wenzeslaus @landam