Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init: Remove duplicate mapset cleaning code, use verbose #2455

Merged
merged 1 commit into from
Jul 27, 2022
Merged

init: Remove duplicate mapset cleaning code, use verbose #2455

merged 1 commit into from
Jul 27, 2022

Conversation

wenzeslaus
Copy link
Member

  • Remove code duplication between init code in grass.py and grass.script.setup for mapset temporary directory cleaning.
  • Simplify the code by using subprocess.DEVNULL instead of os.devnull.
  • Change the cleaning message to verbose.
  • Document both functions.

@wenzeslaus wenzeslaus added this to the 8.4.0 milestone Jul 25, 2022
@wenzeslaus
init: Remove duplicate mapset cleaning code, use verbose
1126d80 
* Remove code duplication between init code in grass.py and grass.script.setup for mapset temporary directory cleaning.
* Simplify the code by using subprocess.DEVNULL instead of os.devnull.
* Change the cleaning message to verbose.
* Document both functions.
@wenzeslaus wenzeslaus marked this pull request as ready for review July 26, 2022 03:23
@wenzeslaus wenzeslaus added enhancement New feature or request Python Related code is in Python labels Jul 26, 2022
@wenzeslaus wenzeslaus merged commit 908325a into OSGeo:main Jul 27, 2022
@wenzeslaus wenzeslaus deleted the simpler-clean-mapset-tmp branch July 27, 2022 10:56
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
@wenzeslaus @ninsbl
init: Remove duplicate mapset cleaning code, use verbose (OSGeo#2455)
d14423e 
* Remove code duplication between init code in grass.py and grass.script.setup for mapset temporary directory cleaning.
* Simplify the code by using subprocess.DEVNULL instead of os.devnull.
* Change the cleaning message to verbose.
* Document both functions.
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
@wenzeslaus @ninsbl
init: Remove duplicate mapset cleaning code, use verbose (OSGeo#2455)
c03a908 
* Remove code duplication between init code in grass.py and grass.script.setup for mapset temporary directory cleaning.
* Simplify the code by using subprocess.DEVNULL instead of os.devnull.
* Change the cleaning message to verbose.
* Document both functions.
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
@wenzeslaus @neteler
init: Remove duplicate mapset cleaning code, use verbose (OSGeo#2455)
527861c 
* Remove code duplication between init code in grass.py and grass.script.setup for mapset temporary directory cleaning.
* Simplify the code by using subprocess.DEVNULL instead of os.devnull.
* Change the cleaning message to verbose.
* Document both functions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request Python Related code is in Python
Projects
None yet
Milestone
8.3.0
Development

Successfully merging this pull request may close these issues.
1 participant
@wenzeslaus