Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init: Decrease verbosity of --exec #2457

Merged
merged 1 commit into from
Jul 27, 2022
Merged

init: Decrease verbosity of --exec #2457

merged 1 commit into from
Jul 27, 2022

Conversation

wenzeslaus
Copy link
Member

@wenzeslaus wenzeslaus commented Jun 21, 2022 •
edited
Loading

  • If --exec or -e (exit with -c) is used, do not show the 'Starting' message. Only one operation will happen, so no need to emphasize there is a session starting.
  • Do not show 'Creating' message for --tmp-location. It is temporary, no need to know it is being created when that's what was requested and it will be deleted at the end.
  • Show 'Executing' and 'Execution...finished' messages only in verbose mode. By default, there is no need to echo the command which was received.
  • Clarify interface of run_batch_job and fix its documentation. Remove unused env var related code.

@wenzeslaus wenzeslaus added this to the 8.4.0 milestone Jul 25, 2022
@wenzeslaus wenzeslaus added the enhancement New feature or request label Jul 26, 2022
@wenzeslaus
init: Decrease verbosity of --exec
a80d0ab 
* If --exec or -e (exit with -c) is used, do not show the 'Starting' message. Only one operation will happen, so no need to emphasize there is a session starting.
* Do not show 'Creating' message for --tmp-location. It is temporary, no need to know it is being created when that's what was requested and it will be deleted at the end.
* Show 'Executing' and 'Execution...finished' messages only in verbose mode. By default, there is no need to eche the command which was recieved.
* Clarify interface of run_batch_job and fix its documentation. Remove unused env var related code.
@wenzeslaus
Copy link
Member Author

This fixes documentation, includes comments, and less verbose --exec was requested in the past. If tests pass, I'll merge this.

@wenzeslaus wenzeslaus added the Python Related code is in Python label Jul 26, 2022
@wenzeslaus wenzeslaus merged commit d59581e into OSGeo:main Jul 27, 2022
@wenzeslaus wenzeslaus deleted the less-verbose-exec branch July 27, 2022 10:55
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
@wenzeslaus @ninsbl
init: Decrease verbosity of --exec (OSGeo#2457)
b72335c 
* If --exec or -e (exit with -c) is used, do not show the 'Starting' message. Only one operation will happen, so no need to emphasize there is a session starting.
* Do not show 'Creating' message for --tmp-location. It is temporary, no need to know it is being created when that's what was requested and it will be deleted at the end.
* Show 'Executing' and 'Execution...finished' messages only in verbose mode. By default, there is no need to echo the command which was received.
* Clarify interface of run_batch_job and fix its documentation. Remove unused env var related code.
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
@wenzeslaus @ninsbl
init: Decrease verbosity of --exec (OSGeo#2457)
2b105fd 
* If --exec or -e (exit with -c) is used, do not show the 'Starting' message. Only one operation will happen, so no need to emphasize there is a session starting.
* Do not show 'Creating' message for --tmp-location. It is temporary, no need to know it is being created when that's what was requested and it will be deleted at the end.
* Show 'Executing' and 'Execution...finished' messages only in verbose mode. By default, there is no need to echo the command which was received.
* Clarify interface of run_batch_job and fix its documentation. Remove unused env var related code.
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
@wenzeslaus @neteler
init: Decrease verbosity of --exec (OSGeo#2457)
71fc462 
* If --exec or -e (exit with -c) is used, do not show the 'Starting' message. Only one operation will happen, so no need to emphasize there is a session starting.
* Do not show 'Creating' message for --tmp-location. It is temporary, no need to know it is being created when that's what was requested and it will be deleted at the end.
* Show 'Executing' and 'Execution...finished' messages only in verbose mode. By default, there is no need to echo the command which was received.
* Clarify interface of run_batch_job and fix its documentation. Remove unused env var related code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request Python Related code is in Python
Projects
None yet
Milestone
8.3.0
Development

Successfully merging this pull request may close these issues.
1 participant
@wenzeslaus