-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
init: Decrease verbosity of --exec #2457
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wenzeslaus
commented
Jun 21, 2022
•
edited
Loading
edited
- If --exec or -e (exit with -c) is used, do not show the 'Starting' message. Only one operation will happen, so no need to emphasize there is a session starting.
- Do not show 'Creating' message for --tmp-location. It is temporary, no need to know it is being created when that's what was requested and it will be deleted at the end.
- Show 'Executing' and 'Execution...finished' messages only in verbose mode. By default, there is no need to echo the command which was received.
- Clarify interface of run_batch_job and fix its documentation. Remove unused env var related code.
* If --exec or -e (exit with -c) is used, do not show the 'Starting' message. Only one operation will happen, so no need to emphasize there is a session starting. * Do not show 'Creating' message for --tmp-location. It is temporary, no need to know it is being created when that's what was requested and it will be deleted at the end. * Show 'Executing' and 'Execution...finished' messages only in verbose mode. By default, there is no need to eche the command which was recieved. * Clarify interface of run_batch_job and fix its documentation. Remove unused env var related code.
wenzeslaus
force-pushed
the
less-verbose-exec
branch
from
July 26, 2022 03:33
ced6434
to
a80d0ab
Compare
This fixes documentation, includes comments, and less verbose |
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Oct 26, 2022
* If --exec or -e (exit with -c) is used, do not show the 'Starting' message. Only one operation will happen, so no need to emphasize there is a session starting. * Do not show 'Creating' message for --tmp-location. It is temporary, no need to know it is being created when that's what was requested and it will be deleted at the end. * Show 'Executing' and 'Execution...finished' messages only in verbose mode. By default, there is no need to echo the command which was received. * Clarify interface of run_batch_job and fix its documentation. Remove unused env var related code.
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Feb 17, 2023
* If --exec or -e (exit with -c) is used, do not show the 'Starting' message. Only one operation will happen, so no need to emphasize there is a session starting. * Do not show 'Creating' message for --tmp-location. It is temporary, no need to know it is being created when that's what was requested and it will be deleted at the end. * Show 'Executing' and 'Execution...finished' messages only in verbose mode. By default, there is no need to echo the command which was received. * Clarify interface of run_batch_job and fix its documentation. Remove unused env var related code.
neteler
pushed a commit
to nilason/grass
that referenced
this pull request
Nov 7, 2023
* If --exec or -e (exit with -c) is used, do not show the 'Starting' message. Only one operation will happen, so no need to emphasize there is a session starting. * Do not show 'Creating' message for --tmp-location. It is temporary, no need to know it is being created when that's what was requested and it will be deleted at the end. * Show 'Executing' and 'Execution...finished' messages only in verbose mode. By default, there is no need to echo the command which was received. * Clarify interface of run_batch_job and fix its documentation. Remove unused env var related code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.