-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wxGUI: implement workspace recent files submenu for single/multiple window mode #2469
wxGUI: implement workspace recent files submenu for single/multiple window mode #2469
Conversation
34551b7
to
dba51c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea and will try to test it, but I was wondering if the functionality should be rather in the WorkspaceManager than as a mixin? I think that would result in fewer changes.
…ltiple window mode" This reverts commit dba51c4.
…indow mode Implementation in the WorkspaceManager class.
I agree with you, I implemented it in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
PR OSGeo#2469 (908c5e2) introduced a code that uses English UI strings to identify UI elements. In the case of a translated UI it fails to get element and then proceeds to manipulate with not existing element leading to an assert in C++ wx code.
PR OSGeo#2469 (908c5e2) introduced a code that uses English UI strings to identify UI elements. In the case of a translated UI it fails to get element and then proceeds to manipulate with not existing element leading to an assert in C++ wx code.
PR OSGeo#2469 (908c5e2) introduced a code that uses English UI strings to identify UI elements. In the case of a translated UI it fails to get element and then proceeds to manipulate with not existing element leading to an assert in C++ wx code.
PR OSGeo#2469 (908c5e2) introduced a code that uses English UI strings to identify UI elements. In the case of a translated UI it fails to get element and then proceeds to manipulate with not existing element leading to an assert in C++ wx code.
Implement workspace recent files submenu for single/multiple window mode (same feature has wxGUI component Simple Python Editor).
Screenshots: