Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxGUI: implement workspace recent files submenu for single/multiple window mode #2469

Merged

Conversation

tmszi
Copy link
Member

@tmszi tmszi commented Jun 28, 2022

Implement workspace recent files submenu for single/multiple window mode (same feature has wxGUI component Simple Python Editor).

Screenshots:

wxgui_single_win_mode_main_menu_workspace_recent_files_submenu

@tmszi tmszi added enhancement New feature or request GUI wxGUI related labels Jun 28, 2022
@tmszi tmszi added this to the 8.4.0 milestone Jun 28, 2022
@tmszi tmszi force-pushed the wxgui_main_win_menu_add_recent_workspace_files_sub_menu branch from 34551b7 to dba51c4 Compare June 28, 2022 21:41
Copy link
Contributor

@petrasovaa petrasovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea and will try to test it, but I was wondering if the functionality should be rather in the WorkspaceManager than as a mixin? I think that would result in fewer changes.

@tmszi
Copy link
Member Author

tmszi commented Jul 16, 2022

I like the idea and will try to test it, but I was wondering if the functionality should be rather in the WorkspaceManager than as a mixin? I think that would result in fewer changes.

I agree with you, I implemented it in the WorkspaceManager class commit no. 3f8c65b.

Copy link
Contributor

@petrasovaa petrasovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@tmszi tmszi merged commit 908c5e2 into OSGeo:main Jul 19, 2022
@tmszi tmszi deleted the wxgui_main_win_menu_add_recent_workspace_files_sub_menu branch July 19, 2022 04:40
marisn added a commit to marisn/grass that referenced this pull request Jul 21, 2022
PR OSGeo#2469 (908c5e2) introduced
a code that uses English UI strings to identify UI elements.
In the case of a translated UI it fails to get element and then
proceeds to manipulate with not existing element leading to
an assert in C++ wx code.
marisn added a commit that referenced this pull request Jul 21, 2022
PR #2469 (908c5e2) introduced
a code that uses English UI strings to identify UI elements.
In the case of a translated UI it fails to get element and then
proceeds to manipulate with not existing element leading to
an assert in C++ wx code.
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
PR OSGeo#2469 (908c5e2) introduced
a code that uses English UI strings to identify UI elements.
In the case of a translated UI it fails to get element and then
proceeds to manipulate with not existing element leading to
an assert in C++ wx code.
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
PR OSGeo#2469 (908c5e2) introduced
a code that uses English UI strings to identify UI elements.
In the case of a translated UI it fails to get element and then
proceeds to manipulate with not existing element leading to
an assert in C++ wx code.
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
PR OSGeo#2469 (908c5e2) introduced
a code that uses English UI strings to identify UI elements.
In the case of a translated UI it fails to get element and then
proceeds to manipulate with not existing element leading to
an assert in C++ wx code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request GUI wxGUI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants