Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxGUI/vselect: fix output fully qualified vector name #2483

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

tmszi
Copy link
Member

@tmszi tmszi commented Jul 17, 2022

Describe the bug
When you created new vector map with Select vector feature(s) tool, map is added into Map Display layers tree. If you try delete this map from the Data Catalog Location current Mapset tree, map isn't deleted from the current Map Display layers tree.

To Reproduce
Steps to reproduce the behavior:

  1. Launch wxGUI
  2. Display some vector map e.g. d.vect map=census
  3. From the Map Display layers tree select census vector map
  4. From the Map Display Frame toolbars activate Select vector feature(s) tool
  5. Select some area(s)
  6. Hit Create new map button from the Select vector feature(s) dialog (new vector map is created e.g. census_selectionW08 and is added into current Map Display layers tree)
  7. Reload Data Catalog Location current Mapset tree (if you don't have installed Data Catalog watchdog Python package) via Data Catalog toolbar Reload current GRASS mapset only tool
  8. From the Data Catalog Location current Mapset tree try delete newly created vector map census_selectionW08
  9. Vector map census_selectionW08 is deleted from the Data Catalog Location current Mapset tree, but isn't deleted from the Map Display layers tree

Expected behavior
If vector map is deleted from the Data Catalog Location current Mapset tree should be deleted from the Map Display layers tree too.

System description (please complete the following information):

  • Operating System: all
  • GRASS GIS version: all

For the correct way to remove a vector map layer from the Map Display
tree if map is removed from the Data Catalog tree.
@tmszi tmszi added bug Something isn't working backport_needed GUI wxGUI related labels Jul 17, 2022
@tmszi tmszi added this to the 8.2.1 milestone Jul 17, 2022
Copy link
Contributor

@petrasovaa petrasovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, thanks!

@tmszi tmszi merged commit bbe4856 into OSGeo:main Jul 19, 2022
@tmszi tmszi deleted the wxgui_vselect_fix_output_vect_full_name branch July 19, 2022 04:14
tmszi added a commit to tmszi/grass that referenced this pull request Jul 19, 2022
For the correct way to remove a vector map layer from the Map Display
tree if map is removed from the Data Catalog tree.
tmszi added a commit to tmszi/grass that referenced this pull request Jul 19, 2022
For the correct way to remove a vector map layer from the Map Display
tree if map is removed from the Data Catalog tree.
tmszi added a commit to tmszi/grass that referenced this pull request Jul 19, 2022
For the correct way to remove a vector map layer from the Map Display
tree if map is removed from the Data Catalog tree.
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
For the correct way to remove a vector map layer from the Map Display
tree if map is removed from the Data Catalog tree.
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
For the correct way to remove a vector map layer from the Map Display
tree if map is removed from the Data Catalog tree.
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
For the correct way to remove a vector map layer from the Map Display
tree if map is removed from the Data Catalog tree.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working GUI wxGUI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants