Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init: Fix sudo message on Ubuntu #2532

Merged
merged 4 commits into from
Oct 7, 2022
Merged

Conversation

susi
Copy link
Contributor

@susi susi commented Aug 20, 2022

Fixes #753 by creating <mapset>/.sudo_as_admin_successful when $HOME/.sudo_as_admin_successful exists

@susi susi added linux Linux specific Python Related code is in Python labels Aug 20, 2022
@susi susi requested a review from wenzeslaus August 20, 2022 18:05
@susi susi added this to the 8.4.0 milestone Aug 20, 2022
@susi susi self-assigned this Aug 20, 2022
Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a comment to the code explaining what it is about, so that one does not have to go all the way to the GitHub issue to see reasoning for this?

Advantages of new file versus copying the file is not clear to me. Either one works at this point I guess.

The Black reformat is unfortunate, but given your plans to restructure grass.py, I think it is fine to leave it here although it unrelated.

@susi
Copy link
Contributor Author

susi commented Aug 28, 2022

Added a massive explanation 😛

lib/init/grass.py Outdated Show resolved Hide resolved
@susi susi requested a review from wenzeslaus August 28, 2022 20:42
@wenzeslaus wenzeslaus merged commit f1491a3 into OSGeo:main Oct 7, 2022
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
Create <mapset>/.sudo_as_admin_successful when $HOME/.sudo_as_admin_successful exists to avoid message about sudo for the a Bash instance for each session.

Contains several unrelated Black changes.

Fixes OSGeo#753.
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
Create <mapset>/.sudo_as_admin_successful when $HOME/.sudo_as_admin_successful exists to avoid message about sudo for the a Bash instance for each session.

Contains several unrelated Black changes.

Fixes OSGeo#753.
marisn pushed a commit to marisn/grass that referenced this pull request Jun 2, 2023
Create <mapset>/.sudo_as_admin_successful when $HOME/.sudo_as_admin_successful exists to avoid message about sudo for the a Bash instance for each session.

Contains several unrelated Black changes.

Fixes OSGeo#753.
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
Create <mapset>/.sudo_as_admin_successful when $HOME/.sudo_as_admin_successful exists to avoid message about sudo for the a Bash instance for each session.

Contains several unrelated Black changes.

Fixes OSGeo#753.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linux Linux specific Python Related code is in Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] Remove run as administrator from startup message in CLI
2 participants