Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checks: Fix i.evapo.pm disabled code for smooth indetation #2579

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

wenzeslaus
Copy link
Member

@wenzeslaus wenzeslaus commented Sep 17, 2022

Disabled code in i.evapo.pm missed one curly bracket which was confusing GNU indent.

@wenzeslaus wenzeslaus added the enhancement New feature or request label Sep 17, 2022
@wenzeslaus wenzeslaus added this to the 8.3.0 milestone Sep 17, 2022
@wenzeslaus wenzeslaus marked this pull request as ready for review September 17, 2022 14:37
@wenzeslaus wenzeslaus changed the title Fix i.evapo.pm and headers for smooth indetation Fix i.evapo.pm disabled code for smooth indetation Feb 10, 2023
@wenzeslaus
Copy link
Member Author

A piece of disabled code in i.evapo.pm missed one curly bracket which was confusing GNU indent. The other changes from this PR were already resolved in code.

@wenzeslaus wenzeslaus merged commit aa51d69 into OSGeo:main Feb 13, 2023
@wenzeslaus wenzeslaus deleted the changes-for-indent branch February 13, 2023 16:03
@wenzeslaus
Copy link
Member Author

Importance of this PR is well-expressed here: https://xkcd.com/859/

ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
This trivial fix for a disabled code in i.evapo.pm is useful for indentation with GNU indent which gets confused by the missing bracket. Now the code preprocessor-disabled code is valid code.
@wenzeslaus wenzeslaus changed the title Fix i.evapo.pm disabled code for smooth indetation contributing: Fix i.evapo.pm disabled code for smooth indetation Jun 6, 2023
@wenzeslaus wenzeslaus changed the title contributing: Fix i.evapo.pm disabled code for smooth indetation checks: Fix i.evapo.pm disabled code for smooth indetation Jun 6, 2023
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
This trivial fix for a disabled code in i.evapo.pm is useful for indentation with GNU indent which gets confused by the missing bracket. Now the code preprocessor-disabled code is valid code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant