Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxGUI: fix setting of user defined window position and size for single window mode #2619

Merged
merged 3 commits into from
Nov 3, 2022

Conversation

tmszi
Copy link
Member

@tmszi tmszi commented Nov 1, 2022

Fixes #2600.

How to test this PR:

  1. Launch wxGUI with single window mode
  2. Change and remember visually wxGUI window size and position
  3. Open wxGUI settings via menu Settings -> Preferences
  4. On the General page (tab) from the Workspace setting check Save current windows layout as default
  5. Hit Preferences dialog Save button
  6. Close wxGUI
  7. Launch wxGUI and check window position and size

If you want to change the wxGUI position and size again, you need to open the wxGUI preferences dialog again and press the Save button again.

Copy link
Contributor

@petrasovaa petrasovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, thank you! I don't think the tuple comparison works well here, it's not the same thing as if w <= GM_WINDOW_SIZE[0] or h <= GM_WINDOW_SIZE[1] if that's what you meant.

@tmszi
Copy link
Member Author

tmszi commented Nov 2, 2022

I don't think the tuple comparison works well here, it's not the same thing as if w <= GM_WINDOW_SIZE[0] or h <= GM_WINDOW_SIZE[1] if that's what you meant.

Yes you are right. Thank you.

@tmszi tmszi merged commit f203376 into OSGeo:main Nov 3, 2022
tmszi added a commit to tmszi/grass that referenced this pull request Nov 3, 2022
@tmszi tmszi deleted the fix-wxgui-single-win-mode-set-pos-and-size branch November 3, 2022 04:57
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
marisn pushed a commit to marisn/grass that referenced this pull request Jun 2, 2023
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working GUI wxGUI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set initial window size in single-window mode - currently default window is too large.
2 participants