t.rast.univar/t.rast3d.univar: add support for multiprocessing #2624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninsbl
added
enhancement
|
I am unable to test this at this time, but on quick review, it looks
like a reasonable solution. I would encourage those who can, please test
this. Temporal modules should greatly benefit from parallelization.
Also note that modern processors can process two threads per core.
Results of timed tests from nprocs to 2*nprocs may or may not be
interesting.
On 11/3/2022 4:49 PM, Stefan Blumentrath wrote:
This PR adds support for multiprocessing to
|python/grass/temporal/univar_statistics.py| and ultimately to
|t.rast.univar| and |t.rast3d.univar|.
A parallel testcase is added. However, thorough testing would be great!
Fixes #2590 <#2590>
------------------------------------------------------------------------
You can view, comment on, or merge this pull request online at:
#2624
Commit Summary
* d4abf62
<d4abf62>
add multiprocessing
* da34cfc
<da34cfc>
add multiprocessing
* f1cc6d3
<f1cc6d3>
add multiprocessing
* 36037e6
<36037e6>
add multiprocessing
* a2f7064
<a2f7064>
add multiprocessing
File Changes
(5 files <https://github.com/OSGeo/grass/pull/2624/files>)
* *M* python/grass/temporal/univar_statistics.py
<https://github.com/OSGeo/grass/pull/2624/files#diff-04627d74bb071d406045cfb19f3b3da489a7ad17e154d1bfbf6c0dbd6f085f84>
(180)
* *M* temporal/t.rast.univar/t.rast.univar.py
<https://github.com/OSGeo/grass/pull/2624/files#diff-4a746bd5e64a26e041d21547bdd2e54af8a237eb04b05c19f9a5a370600f5249>
(7)
* *M* temporal/t.rast.univar/testsuite/test_t_rast_univar.py
<https://github.com/OSGeo/grass/pull/2624/files#diff-c242aba237b81a17332111605d5890493607427db94e008c15a2df550cbae275>
(27)
* *M* temporal/t.rast3d.univar/t.rast3d.univar.py
<https://github.com/OSGeo/grass/pull/2624/files#diff-52754d00fb4bff367dc68c534cc885172bc2432cdbaed18a3b66bff615719a5b>
(7)
* *M* temporal/t.rast3d.univar/testsuite/test_t_rast3d_univar.py
<https://github.com/OSGeo/grass/pull/2624/files#diff-645d893ca58fae6d5a330d7ff36019f6b3c177d0f75600b4b2f899dd09880849>
(37)
Patch Links:
* https://github.com/OSGeo/grass/pull/2624.patch
* https://github.com/OSGeo/grass/pull/2624.diff
—
Reply to this email directly, view it on GitHub
<#2624>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQZTHVI2ALJ2O5NHLL2GICTWGRFRPANCNFSM6AAAAAARWVKDOQ>.
You are receiving this because you are subscribed to this
thread.Message ID: ***@***.***>
--
Best Regards,
-Brad
|
petrasovaa
approved these changes
Nov 10, 2022
|
|
||
| ############################################################################### | ||
|
|
||
|
|
||
| def compute_univar_stats(row, stats_module, fs, rast_region=False): |
There was a problem hiding this comment.
I understand where the row came from, but it is rather weird as a function parameter name...
There was a problem hiding this comment.
parameter name and documentation updated in: 12eec61
| def compute_univar_stats(row, stats_module, fs, rast_region=False): | ||
| """Compute univariate statistics for a map of a space time raster or raster3d dataset | ||
|
|
||
| :param row: Must be "strds" or "str3ds" |
There was a problem hiding this comment.
This looks like is must string "strds" or "str3ds", so probably just drop the quotes.
There was a problem hiding this comment.
Updated docstring in 12eec61
Comment on lines
218
to
219
| pool.close() | ||
| pool.join() |
There was a problem hiding this comment.
I believe these are not doing anything here, close and join would be useful for starmap_async.
ninsbl
added a commit
to ninsbl/grass
that referenced
this pull request
Feb 17, 2023
…#2624) * add multiprocessing * implement suggestions from review
marisn
pushed a commit
to marisn/grass
that referenced
this pull request
Jun 2, 2023
…#2624) * add multiprocessing * implement suggestions from review
neteler
pushed a commit
to nilason/grass
that referenced
this pull request
Nov 7, 2023
…#2624) * add multiprocessing * implement suggestions from review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for multiprocessing to
python/grass/temporal/univar_statistics.pyand ultimately tot.rast.univarandt.rast3d.univar.A parallel testcase is added. However, thorough testing would be great!
Fixes #2590