-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: add macOS build #2661
CI: add macOS build #2661
Conversation
"macOS / macOS build (pull_request) Successful in 17m" Superb 💯 (also compared to the Ubuntu CI "speed" here) |
Notably, this is currently without tests unlike the Ubuntu CI. For speed, compare with GCC C/C++ standards check instead. |
# This file may be used to create an environment using: | ||
# $ conda create --name <env> --file <this file> | ||
# platform: osx-64 | ||
@EXPLICIT | ||
https://conda.anaconda.org/conda-forge/osx-64/pandoc-2.19.2-h694c41f_1.tar.bz2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with this type of file, so I'm wondering why this file and not an environment.yml file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is also an environment file, only with explicit packages. I took it from https://github.com/nilason/grass-conda for speed and predictability. Turned out an ordinary type of file doesn't make much difference in time. If predictability will be an issue we'll return to this question. I now changed to standard file, easier to maintain.
Compile time is decent, nothing spectacular. Testing is not particularly fast. |
I have now opened this for review. Following tests fails: r.in.pdal
r.sun
Testreport available as artefact. |
Now added using cache for deps, saving ~3 min. |
As an alternative to test success percentage, you could also disable specific tests, but at this point you would have to duplicate the whole test configuration in the |
Oops, this installs grass into environment before caching, thus includes initial build of grass into cache. Not so good. Either remove or different install dir... |
I don't quickly see why is that, but the 3 mins may not be worth the trouble given the total time (the time fluctuation of GCC seems about 3 mins or so). |
See log extract:
Now I added separate install dir. Let's see how it works out. (No trouble on my side :) |
How would I duplicate the |
The test executor has a
The file could be in |
Aha, thanks! |
adbb0d7
to
4f4b8c1
Compare
Remains three tests which often fails on CI, but passes ! locally:
The (See test report) |
The
"code: -11" is likely a segmentation fault. |
I am inclined to merge this now. Better to have this running as is, even with the somewhat limited test range. The following test files are added to the content of the main exclusion list (.gunittest.cfg), but in separate config file:
The last three only fails on the CI for some strange reason(s). |
23e8ed5
to
584115d
Compare
584115d
to
718b729
Compare
This now runs with |
Add a macOS build with tests on the CI.