-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r.univar: parallelization for extended statistics #2683
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronsms
changed the title
[Draft] r.univar parallelization for extended statistics
r.univar parallelization for extended statistics
Dec 5, 2022
aaronsms
force-pushed
the
r-univar_parallel_extended
branch
from
March 4, 2023 08:36
b465a06
to
12c95e9
Compare
I didn't test yet, but you need to remove the restriction that prevented r.univar -e to run in parallel: |
Weird, the tests in CI work, I am getting locally a lot of errors, e.g.:
|
It did not
The last commit should fix this. We should test it more. |
petrasovaa
approved these changes
Jun 5, 2023
HuidaeCho
pushed a commit
to HuidaeCho/grass
that referenced
this pull request
Jan 9, 2024
neteler
changed the title
r.univar parallelization for extended statistics
r.univar: parallelization for extended statistics
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addressed #2564, completing parallelization for extended statistics.
The key idea is to maintain "local buckets" for each thread to sort their cells according to the different zones before transfering to the global buffer for computing the order statistics.
In the case of nprocs=1, care is taken to ensure no major overhead, as the first transfer would just be a redirection to the local bucket.
Performance benchmark still needs to be done.