Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake build environment with Visual Studio support #2684
CMake build environment with Visual Studio support #2684
Changes from all commits
616be6a
98cb9a0
a1c304b
2572080
637160d
d505352
0099daa
297f2b3
77c79a1
f590798
b79ac0e
a189cb7
b957a81
0d4e0da
20c00ba
c158111
44acbfa
4e8ddc7
ab8a0a3
0834a87
ec65ecb
e094369
7aeb0b6
2838cc9
74207c5
ea058ff
5f1dcf0
3cb0241
2e0e73b
f258904
816b835
3eae792
c160dd5
644abd4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... this still fails in the CI (using CMake 3.11.4). It still a more recent CMake version needed? (I cannot find any more the related comment by @echoix)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#2684 (comment)
The default version in Ubuntu 20.04 is 3.16.x, and GitHub runners already include 3.25.1.
That was a "new"-ish recommended syntax, but introduced in 3.13
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which version to be used, do you have any recommendation (e.g., we may try 3.13 - or later)?