Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v.in.ogr: Get layer name without definition initialization #2740

Merged
merged 2 commits into from
Jan 13, 2023

Conversation

frafra
Copy link
Contributor

@frafra frafra commented Jan 9, 2023

Fix #2738.

Tested. No regression found.

@frafra
Copy link
Contributor Author

frafra commented Jan 9, 2023

Is this patch eligible to be backported to OSGeo:releasebranch_7_8?

@neteler neteler requested a review from metzm January 10, 2023 09:00
@neteler neteler changed the title Get layer name without definition initialization v.in.ogr: Get layer name without definition initialization Jan 10, 2023
@neteler neteler added bug Something isn't working vector Related to vector data processing C Related code is in C labels Jan 10, 2023
@frafra
Copy link
Contributor Author

frafra commented Jan 10, 2023

clang-format complained about my code style, but I was just using the previous convention. I fixed the style error.

@nilason
Copy link
Contributor

nilason commented Jan 10, 2023

clang-format complained about my code style, but I was just using the previous convention. I fixed the style error.

Your changes only shortened the code, thus now fits in one line (80 col).
There is nowadays (only recently added and accompanying updated submitting guides are still missing [note to myself!]) only one formatting "convention" and that is clang-format.

@frafra
Copy link
Contributor Author

frafra commented Jan 10, 2023

Your changes only shortened the code, thus now fits in one line (80 col). There is nowadays (only recently added and accompanying updated submitting guides are still missing [note to myself!]) only one formatting "convention" and that is clang-format.

Oh, right, got it, thank you :)

@nilason
Copy link
Contributor

nilason commented Jan 10, 2023

This looks like a reasonable change to me.
Considering GRASS GIS 7.8.8RC3 has been released, only breaking fixes should go to 7.8.8 at this time, this doesn't seem like such...

@frafra
Copy link
Contributor Author

frafra commented Jan 10, 2023

There is a failing test, but it is because of a timeout, not because of my code.

Copy link
Contributor

@metzm metzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. This is what the GDAL API documentation actually recommends: https://gdal.org/doxygen/ogr__api_8h.html#a88facf4f8e8b32278101d52ae094255c

@neteler neteler added this to the 8.3.0 milestone Jan 13, 2023
@nilason nilason merged commit 70b6d0d into OSGeo:main Jan 13, 2023
@nilason
Copy link
Contributor

nilason commented Jan 13, 2023

@frafra Thanks very much!

@frafra frafra deleted the remove-useless-getlayerdef branch January 13, 2023 19:55
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working C Related code is in C vector Related to vector data processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] GRASS reads all the layers when using v.in.ogr with WFS3/OAIPIF
5 participants