-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wxGUI Console: Button reorganization #2746
wxGUI Console: Button reorganization #2746
Conversation
I am thinking about the suggestion and I still do not like the way how buttons are organized. All buttons are actually more related to Console Output than to Command Prompt. We could probably preserve Clear button for Command Prompt and put two buttons Save and Clear to the bottom of Console Output and two buttons Export history and Clear to the bottom of Command prompt.. So we would clearly present what button belongs to which widget. Any ideas or disagreeing comments on this? :-) |
I like the idea of putting the buttons where they belong to ;) |
Good. I implemented it according to the last suggestion. If I make the right pane really narrow it looks as follows: @petrasovaa, do you have any suggestions on this? |
I don't have a better solution right now. How are the buttons aligned? I would align them all probably to the right, but no strong opinion. |
I'd also align them to the right |
I agree with you Vero and Anna, aligning to the right side looks better: |
Well, I think that |
What about considering the whole thing one larger widget? Then there would be one row with three buttons in the bottom:
Clear would clear both input and output. This suggestion avoids two Clear buttons and two rows of buttons. |
I agree, I think the interface will look better. |
Well... The layout you are proposing is basically very similar to what I implemented at the beginning of this PR.. :-D I like the idea of merging Clear button into one Clear button but I still think that we do not solve the problem of lack of space... The button widget is too wide and it will not look good with the default settings of the right panel width... but I can go back in the commit history and implement your proposal and we can then decide what is better... |
Regarding the width, the output of r.info etc. is anyway rather wide, so you end up extending it anyway. And this is still an improvement comparing to the current state. Unrelated, it would be nice to make the console space little taller (less narrow), right now the space for typing is rather narrow and long commands don't fit. |
…r buttons is merged to one clear button
0c5452c
to
1ba40fb
Compare
Do you mean the whole right pane make a bit wider or just put the splitter inside the Console pane higher (so that the space for Prompt would be taller)? I made the minimum height of the Prompt greater:
instead of
|
I would suggest making this change:
It makes the Sash position looser and the size is determined by the size of the inner two widgets. With these settings, the Console Prompt takes about one third of the Console size. What do you think @petrasovaa ? |
* now we have just one clear button to clear both output and prompt * larger prompt area
* now we have just one clear button to clear both output and prompt * larger prompt area
This PR solves two things:
Before:
The main problem was that the right part of the button line could be cut off in Single-Window GUI (simply by shrinking the side Console pane):
After:
The suggestion is very similar to the solution in other panes (Tools, Python).
Follows the suggestion in #2585 (comment).