Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r.geomorphon: fix -Wextra compiler warning #2754

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

nilason
Copy link
Contributor

@nilason nilason commented Jan 16, 2023

The warning issued:

warning: ordered comparison of pointer with integer zero [-Wextra]

referring to pattern->distance > 0

In addition changes unused return type int to void for radial2cartesian().

Fixes partly #2747.

The warning issued:
"warning: ordered comparison of pointer with integer zero [-Wextra]"
referring to `pattern->distance > 0`.

In addition changes unused return type int to void for radial2cartesian()
@nilason nilason mentioned this pull request Jan 16, 2023
12 tasks
@nilason nilason added enhancement New feature or request C Related code is in C labels Jan 16, 2023
@nilason nilason added this to the 8.3.0 milestone Jan 16, 2023
@nilason nilason merged commit c3845b2 into OSGeo:main Jan 18, 2023
@nilason nilason deleted the 05_fix_r-geomorphon_Wextra branch January 18, 2023 15:53
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
The warning issued:
"warning: ordered comparison of pointer with integer zero [-Wextra]"
referring to `pattern->distance > 0`.

In addition changes unused return type int to void for radial2cartesian()
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
The warning issued:
"warning: ordered comparison of pointer with integer zero [-Wextra]"
referring to `pattern->distance > 0`.

In addition changes unused return type int to void for radial2cartesian()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C Related code is in C enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant