Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contributing: Add submitting guidelines from GRASS Trac wiki #2765

Merged
merged 7 commits into from
Jan 27, 2023
Merged

contributing: Add submitting guidelines from GRASS Trac wiki #2765

merged 7 commits into from
Jan 27, 2023

Conversation

nilason
Copy link
Contributor

@nilason nilason commented Jan 20, 2023

Following discussion on PSC Meeting in August 2022
I have converted the the html documents of https://trac.osgeo.org/grass/wiki/Submitting to markdown.

Present state of the files is a straightforward conversion, without updates, which may follow the initial commit. The destination of the files can be discussed.

@neteler
Copy link
Member

neteler commented Jan 21, 2023

Thanks for this huge work, @nilason !

BTW: one can see the MD files in a rendered way like this:

  • go to "Files changed" tab
  • then on the right side 3-dots menu: "View file":

image

@nilason
Copy link
Contributor Author

nilason commented Jan 21, 2023

@neteler Thanks! Just committed your suggestions.

@neteler neteler added the manual Documentation related issues label Jan 23, 2023
@nilason nilason marked this pull request as ready for review January 26, 2023 11:08
@nilason @neteler
Apply suggestions from code review 2
76c29c7 
Co-authored-by: Markus Neteler <neteler@osgeo.org>
@nilason
Copy link
Contributor Author

nilason commented Jan 26, 2023

@neteler Thanks!

Re: updating the docs for latest changes with clang-format, I was thinking to make a new PR for that (and maybe some more related stuff). That way the "original" will be in git history and it will be easier to discuss/review modifications.

@nilason
Copy link
Contributor Author

nilason commented Jan 27, 2023

Now I fixed some more links. I think it's quite ok now, from a "just a conversion to .md" point of view.
Further changes of content is subject for follow-up PRs.
If the destination dir for the files: doc/development/submitting/ is ok, then I'd say this is ready for merge.

neteler
neteler approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@neteler neteler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nilason nilason merged commit 7ce5e28 into OSGeo:main Jan 27, 2023
@nilason
Copy link
Contributor Author

nilason commented Jan 27, 2023

Merged, thanks you @neteler !!

@nilason nilason deleted the add_submitting_wiki_files branch January 27, 2023 12:02
@neteler neteler added this to the 8.3.0 milestone Feb 13, 2023
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
@nilason @neteler @ninsbl
docs: Add submitting guidelines (OSGeo#2765)
238818b 
Adds submitting guideline files from GRASS wiki
https://trac.osgeo.org/grass/wiki/Submitting
converted to Markdown format.

Mostly straightforward conversion, obsolete parts relating the use of
SVN were omitted.

See: https://trac.osgeo.org/grass/wiki/PSC/Minutes/PSC_Meeting_20220812

Co-authored-by: Markus Neteler <neteler@osgeo.org>
@wenzeslaus wenzeslaus changed the title Add submitting guidelines from grass-wiki contributing: Add submitting guidelines from GRASS wiki Jun 6, 2023
@wenzeslaus wenzeslaus changed the title contributing: Add submitting guidelines from GRASS wiki contributing: Add submitting guidelines from GRASS Trac wiki Jun 6, 2023
neteler added a commit to nilason/grass that referenced this pull request Nov 7, 2023
@nilason @neteler
docs: Add submitting guidelines (OSGeo#2765)
4e08295 
Adds submitting guideline files from GRASS wiki
https://trac.osgeo.org/grass/wiki/Submitting
converted to Markdown format.

Mostly straightforward conversion, obsolete parts relating the use of
SVN were omitted.

See: https://trac.osgeo.org/grass/wiki/PSC/Minutes/PSC_Meeting_20220812

Co-authored-by: Markus Neteler <neteler@osgeo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neteler neteler neteler approved these changes

Assignees
No one assigned
Labels
manual Documentation related issues
Projects
None yet
Milestone
8.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nilason @neteler