wxGUI: Change caption of Data Catalog to Data #2833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The multi-window layout is/was using just Data which worked well, so this changes the label of the pane/panel to just Data for simplicity and consistency. Now both the top caption and notebook page label (if in a notebook) are Data.
wenzeslaus
added
enhancement
|
And does the translation keys need to be updated to uniformise the names in other languages too? |
|
I'm happy to take an advise on that. |
petrasovaa
reviewed
Feb 16, 2023
gui/wxpython/main_window/frame.py
Outdated
| @@ -614,7 +614,7 @@ def BuildPanes(self): | |||
| self.datacatalog, | |||
| aui.AuiPaneInfo() | |||
| .Name("datacatalog") | |||
| .Caption("Data Catalog") | |||
| .Caption("Data") | |||
There was a problem hiding this comment.
I think these should be translatable. At least they are translatable in multiple-window GUI.
There was a problem hiding this comment.
Thanks for catching that. None of the pane captions were translatable. Fixed.
neteler
pushed a commit
to nilason/grass
that referenced
this pull request
Nov 7, 2023
The multi-window layout is/was using just Data which worked well, so this changes the label of the pane/panel to just Data for simplicity and consistency. Now both the top caption and notebook page label (if in a notebook) are Data. Makes all pane captions translatable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The multi-window layout is/was using just Data which worked well, so this changes the label of the pane/panel to just Data for simplicity and consistency. Now both the top caption and notebook tab/page label (if in a notebook) are Data.
Screenshot Before: Single-window layout
A layout similar to the multi-window interface - all floating panels placed together in one notebook.
Screenshot After: Single-window layout
Same layout as above. Before this PR, the Data tab would be Data Catalog.
Screenshot for Comparison: Multi-window layout
Data catalog is under Data tab (unchanged by this PR).