Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t.rename: Fix error with SQLDatabaseInterface.update() #2886

Merged
merged 6 commits into from
Mar 17, 2023

Conversation

ninsbl
Copy link
Member

@ninsbl ninsbl commented Mar 11, 2023

Improved support for TGIS across mapsets introduced a regression that made t.rename fail. This PR fixes the issue reported in #2848 and adds the existing Shell-script tests to the testsuite in Python.

@ninsbl ninsbl added bug Something isn't working temporal Related to temporal data processing Python Related code is in Python labels Mar 11, 2023
@ninsbl ninsbl added this to the 8.3.0 milestone Mar 11, 2023
@ninsbl ninsbl requested review from metzm and veroandreo March 11, 2023 23:07
@veroandreo
Copy link
Contributor

Works as expected, thanks!
The PR include changes in g.extension that do not seem relevant to the t.rename change though, seems you branched over those changes :)

@ninsbl
Copy link
Member Author

ninsbl commented Mar 13, 2023

Thanks @veroandreo . I reverted the accidental commit for g.extension...

@veroandreo
Copy link
Contributor

It would be nice to have this fix in 8.3, will you merge @ninsbl ?

@ninsbl ninsbl merged commit b38d109 into OSGeo:main Mar 17, 2023
@ninsbl ninsbl deleted the t_rename_mapset branch March 17, 2023 12:44
ninsbl added a commit to ninsbl/grass that referenced this pull request Mar 20, 2023
* convert unittest to python and activate it

* remove "mapset" kwarg from .update() function
ninsbl added a commit to ninsbl/grass that referenced this pull request Mar 20, 2023
* convert unittest to python and activate it

* remove "mapset" kwarg from .update() function
ninsbl added a commit that referenced this pull request Mar 23, 2023
…2886) (#2900)

* convert unittest to python and activate it

* remove "mapset" kwarg from .update() function
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
* convert unittest to python and activate it

* remove "mapset" kwarg from .update() function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Python Related code is in Python temporal Related to temporal data processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants