-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add thanks to all contributors to main README.md #2947
Conversation
Add an auto-generated section listing all contributors with their icons. Make this README.md file less boring :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beautiful ❤️
Oh no! How is possible that this got merged?!? As I have enabled pre-commit hook (thanks @nilason ) now I can not commit anything unless I change this code too – a no-no in the middle of a merge.
|
markdown-lint: exclude README.md from 033-no-inline-html.md, i.e. allow inline HTML in README.md. Addresses OSGeo#2947 (comment)
Done both, see #2971 |
I think |
With that said, this should not happen. I understood that a check in CI is not possible yet because the not all files are compliant yet and doing only the "PR diff" is not readily available. Please, correct me if if I'm wrong, @nilason. |
Temporarily disabling hooks: https://pre-commit.com/#temporarily-disabling-hooks
To that I absolutely agree!
You're essentially right, but let me elaborate: The main problem is that the At the time I introduced pre-commit all files in repo were passing the checks (with the rules and exceptions in I figured using superlinter is close enough (and considering its ease of use and with the main advantage to avoid unnecessary CI runs, everyone would use pre-commit anyway...), but close enough is obviously not good enough! Back then I flagged for the the possible solution for this might be https://pre-commit.ci, but I haven't got to it to explore how that might be implemented. |
* pre-commit-config.yaml: exclude README.md from markdown-lint markdown-lint: exclude README.md from 033-no-inline-html.md, i.e. allow inline HTML in README.md. Addresses #2947 (comment) Co-authored-by: Nicklas Larsson <n_larsson@yahoo.com>
* pre-commit-config.yaml: exclude README.md from markdown-lint markdown-lint: exclude README.md from 033-no-inline-html.md, i.e. allow inline HTML in README.md. Addresses #2947 (comment) Co-authored-by: Nicklas Larsson <n_larsson@yahoo.com>
Add an auto-generated section listing all contributors with their icons. Makes this README.md file less boring :-)
) * pre-commit-config.yaml: exclude README.md from markdown-lint markdown-lint: exclude README.md from 033-no-inline-html.md, i.e. allow inline HTML in README.md. Addresses OSGeo#2947 (comment) Co-authored-by: Nicklas Larsson <n_larsson@yahoo.com>
Add an auto-generated section listing all contributors with their icons at the bottom of
README.md
.Make this README.md file less boring :-)
Uses:
https://contrib.rocks/preview?repo=OSGeo%2Fgrass