Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r.univar: print only statistics for existing zones #2957

Merged
merged 2 commits into from
May 15, 2023
Merged

r.univar: print only statistics for existing zones #2957

merged 2 commits into from
May 15, 2023

Conversation

ninsbl
Copy link
Member

@ninsbl ninsbl commented May 12, 2023

Fix for #2956

@ninsbl ninsbl added backport_needed raster Related to raster data processing C Related code is in C labels May 12, 2023
@ninsbl ninsbl added this to the 8.3.0 milestone May 12, 2023
@ninsbl ninsbl requested review from wenzeslaus and metzm May 12, 2023 19:29
@ninsbl
Copy link
Member Author

ninsbl commented May 14, 2023

If there are no objections I merge this relatively simple fix tonight... The test failure seems unrelated...

wenzeslaus
wenzeslaus reviewed May 15, 2023
View reviewed changes
Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay. I think the current output is wrong because it prints non-existent categories. I'm not sure about how non-existent versus not present in the computational region, but I guess that's the same for -t. Adding a test would clarify the desired behavior. The test will become part of code and the commit rather than just commit linking the PR and PR linking the issue which has an example.

@ninsbl
Copy link
Member Author

ninsbl commented May 15, 2023

Adding a test would clarify the desired behavior. The test will become part of code and the commit rather than just commit linking the PR and PR linking the issue which has an example.

Thanks for looking into this. Right. Now I added a test for this case...

@ninsbl ninsbl merged commit 3e0c87a into OSGeo:main May 15, 2023
@wenzeslaus wenzeslaus removed the request for review from metzm May 17, 2023 12:45
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
@ninsbl @neteler
r.univar: print only statistics for existing zones (OSGeo#2957)
db7aacd 
* skip zones without pixels

* add test for zones with gaps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenzeslaus wenzeslaus wenzeslaus left review comments

Assignees
No one assigned
Labels
C Related code is in C raster Related to raster data processing
Projects
None yet
Milestone
8.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ninsbl @wenzeslaus @landam