-
-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
t.rast.algebra/testsuite: split file test_raster_algebra.py #2974
t.rast.algebra/testsuite: split file test_raster_algebra.py #2974
Conversation
In order to address the frequent CI timeout during execution of the `test_raster_algebra.py` file this file is split into two parts with roughly similar test duration.
Alternatively, we could increase the time out if you think it is really this one test hitting the time limit as opposed to hanging forever. The limit was set in 89fe85c (#2172). While the temporal timeouts are a long-term issue (#2185), the recent flood of failures is due to various network issues (OSGeo for sample data and others for dependencies). A series of failures is also due to g.extension like this run on main for #2966 which timed out and gave:
This run for #2955 fails with just like the first attempt of runs for this PR:
In grass-addons, the CI jobs are often canceled by GitHub automation after exceeding 6 hours with the following as the last line (like this one for OSGeo/grass-addons#606):
|
If you run the t.rast.algebra test locally, it clocks in just around the timeout value. So, for this particular test, increasing the timeout threshold will help... |
Confirmed also here, that's why I have split it (thematically) into two files with runtime of ~ 50% timeout each.
Since the timeout now happened elsewhere, we might consider that in addition. |
TimingThese are times coming directly from the test report generated in the CI. The main branch
This PR
Total: 5 min 23 sec (setup happens once for each test) |
Since you were able to split them thematically can you please name them that way. Splitting the long file thematically is actually best regardless of the times. |
Files renamed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't really evaluate the names, but the names and shorter files are nice. Let's merge it.
In order to address the frequent CI timeout during execution of the `test_raster_algebra.py` file this file is split into two parts with roughly similar test duration. Also rename split files.
In order to address the frequent CI timeout during execution of the `test_raster_algebra.py` file this file is split into two parts with roughly similar test duration. Also rename split files.
In order to address the frequent CI timeout during execution of the
test_raster_algebra.py
file this file is split into two parts with roughly similar test duration.